[Findit] Fix flaky dashboard test.

appengine/findit/handlers/crash/test/fracas_dashboard_test.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import base64
 import copy
 from datetime import datetime
 from datetime import time
 from datetime import timedelta
 import json
 
 import webapp2
 
 from testing_utils import testing
 
 from common import time_util
 from handlers.crash import fracas_dashboard
 from model import analysis_status
 from model import result_status
 from model import triage_status
 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
 
-# TODO: Remove, see crbug.com/624998
-#pylint: disable=unused-variable
 
 class FracasDashBoardTest(testing.AppengineTestCase):
   app_module = webapp2.WSGIApplication(
       [('/fracas-dashboard', fracas_dashboard.FracasDashBoard), ], debug=True)
 
   def setUp(self):
     super(FracasDashBoardTest, self).setUp()
     self.keys = self._AddAnalysisResults()
     self.fracas_crashes = []
     for key in self.keys:
       self.fracas_crashes.append(self._GenerateDisplayData(key))
 
-    midnight_today = datetime.combine(datetime.utcnow(), time.min)
-    midnight_yesterday = midnight_today - timedelta(days=1)
-    midnight_tomorrow = midnight_today + timedelta(days=1)
-    self.default_start_date = midnight_yesterday
-    self.default_end_date = midnight_tomorrow
+    self.default_start_date = datetime(2016, 7, 3, 0, 0, 0, 0)
+    self.default_end_date = datetime(2016, 7, 5, 0, 0, 0, 0)
 
   def testFracasDashBoardHandler(self):
     response = self.test_app.get('/fracas-dashboard')
     self.assertEqual(200, response.status_int)
 
   def _CreateAnalysisResult(self, crash_identifiers):
     analysis = FracasCrashAnalysis.Create(crash_identifiers)
     analysis.status = analysis_status.RUNNING
     return analysis
 
@@ skipping 61 matching lines @@
                           'suspected_project': 'chromium',
                           'regression_range': ['53.0.2749.0', '53.0.2750.0']}
     analyses[3].found_suspects = True
     analyses[4].result = {'found': False,
                           'suspected_cls': [],
                           'suspected_components': ['Blink>API', 'Blink>DOM'],
                           'suspected_project': 'chromium',
                           'regression_range': ['53.0.2749.0', '53.0.2750.0']}
     analyses[4].found_suspects = False
 
-    start_request_time = datetime.utcnow()
-    for i, analysis in enumerate(analyses):
-      analysis.requested_time = (start_request_time +
-                                 timedelta(minutes=10 * i))
-
-      analysis.has_regression_range = not analysis.result[
-          'regression_range'] is None
-
     self._SetResultsTriageStatus(analyses[0], triage_status.TRIAGED_INCORRECT)
     self._SetResultsTriageStatus(analyses[1], triage_status.TRIAGED_CORRECT)
     self._SetResultsTriageStatus(analyses[3], triage_status.TRIAGED_CORRECT)
     self._SetResultsTriageStatus(analyses[4], triage_status.TRIAGED_UNSURE)
 
-    for analysis in analyses:
+    for i, analysis in enumerate(analyses):
+      analysis.requested_time = (datetime(2016, 7, 4, 12, 50, 17, 0) +
+                                 timedelta(seconds=10 * i))
+      analysis.has_regression_range = not analysis.result[
+          'regression_range'] is None
       analysis.put()
 
     return keys
 
   def _GenerateDisplayData(self, crash_identifiers):
     crash = FracasCrashAnalysis.Get(crash_identifiers)
     return {
         'signature': crash.signature,
         'version': crash.crashed_version,
         'channel': crash.channel,
@@ skipping 16 matching lines @@
                            self.fracas_crashes[1],
                            self.fracas_crashes[0]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': '-1',
         'found_suspects': '-1',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
-    response_json = self.test_app.get('/fracas-dashboard?format=json')
+    response_json = self.test_app.get('/fracas-dashboard?format=json'
+                                      '&start_date=2016-07-03'
+                                      '&end_date=2016-07-05')
     self.assertEqual(200, response_json.status_int)
-    # TODO: Re-enable, see crbug.com/624998
-    # self.assertEqual(expected_result, response_json.json_body)
+    self.assertEqual(expected_result, response_json.json_body)
 
   def testFilterWithFoundSuspects(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[3],
                            self.fracas_crashes[0]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': '-1',
         'found_suspects': 'yes',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
     response_json = self.test_app.get(
-        '/fracas-dashboard?found_suspects=yes&format=json')
+        '/fracas-dashboard?found_suspects=yes&format=json'
+        '&start_date=2016-07-03&end_date=2016-07-05')
     self.assertEqual(200, response_json.status_int)
     self.assertEqual(expected_result, response_json.json_body)
 
   def testFilterWithHasRegression(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[4],
                            self.fracas_crashes[3],
                            self.fracas_crashes[2]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': '-1',
         'found_suspects': '-1',
         'has_regression_range': 'yes',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
     response_json = self.test_app.get(
-        '/fracas-dashboard?has_regression_range=yes&format=json')
+        '/fracas-dashboard?has_regression_range=yes&format=json'
+        '&start_date=2016-07-03&end_date=2016-07-05')
     self.assertEqual(200, response_json.status_int)
-    # TODO: Re-enable, see crbug.com/624998
-    # self.assertEqual(expected_result, response_json.json_body)
+    self.assertEqual(expected_result, response_json.json_body)
 
   def testFilterWithSuspectsUntriaged(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[2]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': str(triage_status.UNTRIAGED),
         'found_suspects': '-1',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
     response_json = self.test_app.get(
-        '/fracas-dashboard?suspected_cls_triage_status=%d&format=json' %
-        triage_status.UNTRIAGED)
+        '/fracas-dashboard?suspected_cls_triage_status=%d&format=json'
+        '&start_date=2016-07-03&end_date=2016-07-05' % triage_status.UNTRIAGED)
     self.assertEqual(200, response_json.status_int)
     self.assertEqual(expected_result, response_json.json_body)
 
   def testFilterWithSuspectsTriagedUnsure(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[4]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': str(triage_status.TRIAGED_UNSURE),
         'found_suspects': '-1',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
     response_json = self.test_app.get(
-        '/fracas-dashboard?suspected_cls_triage_status=%d&format=json' %
+        '/fracas-dashboard?suspected_cls_triage_status=%d&format=json'
+        '&start_date=2016-07-03&end_date=2016-07-05' %
         triage_status.TRIAGED_UNSURE)
     self.assertEqual(200, response_json.status_int)
-    # TODO: Re-enable, see crbug.com/624998
-    # self.assertEqual(expected_result, response_json.json_body)
+    self.assertEqual(expected_result, response_json.json_body)
 
   def testFilterWithRegressionRangeTriagedUnsure(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[4]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': str(triage_status.TRIAGED_UNSURE),
         'suspected_cls_triage_status': '-1',
         'found_suspects': '-1',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
     response_json = self.test_app.get(
-        '/fracas-dashboard?regression_range_triage_status=%d&format=json' %
+        '/fracas-dashboard?regression_range_triage_status=%d&format=json'
+        '&start_date=2016-07-03&end_date=2016-07-05' %
         triage_status.TRIAGED_UNSURE)
     self.assertEqual(200, response_json.status_int)
-    # TODO: Re-enable, see crbug.com/624998
-    # self.assertEqual(expected_result, response_json.json_body)
+    self.assertEqual(expected_result, response_json.json_body)
 
   def testGetTopCountResults(self):
     expected_result = {
         'fracas_crashes': [self.fracas_crashes[4],
                            self.fracas_crashes[3]],
         'end_date': time_util.FormatDatetime(self.default_end_date),
         'regression_range_triage_status': '-1',
         'suspected_cls_triage_status': '-1',
         'found_suspects': '-1',
         'has_regression_range': '-1',
         'start_date': time_util.FormatDatetime(self.default_start_date)
     }
 
-    response_json = self.test_app.get('/fracas-dashboard?count=2&format=json')
+    response_json = self.test_app.get('/fracas-dashboard?count=2&format=json'
+                                      '&start_date=2016-07-03'
+                                      '&end_date=2016-07-05')
     self.assertEqual(200, response_json.status_int)
-    # TODO: Re-enable, see crbug.com/624998
-    # self.assertEqual(expected_result, response_json.json_body)
+    self.assertEqual(expected_result, response_json.json_body)