Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2147633002: Remove nonstandard 'endings' option for Blob/File constructor (Closed)

Created:
4 years, 5 months ago by jsbell
Modified:
3 years, 7 months ago
Reviewers:
foolip
CC:
chromium-reviews, tzik, tfarina, nhiroki, haraken, blink-reviews, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove nonstandard 'endings' option for Blob/File constructor new Blob([data], {endings: 'native'}); new File([data], 'filename', {endings: 'native'}); ... which translates '\n' in the data to '\r\n' on Windows. This has never been supported in other browsers, and use counters show only 0.0000000002% usage and no hits in HTTPArchive. Remove the option and associated plumbing. Intent to Remove: ****TBD**** Chrome Status: ****TBD**** BUG=605710 R=foolip@chromium.org

Patch Set 1 #

Patch Set 2 : Fix unit test #

Patch Set 3 : Layout test updates #

Total comments: 1

Patch Set 4 : Remove lingering traces of 'endings' in Blink tests #

Patch Set 5 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+981 lines, -248 lines) Patch
M third_party/WebKit/LayoutTests/fast/files/blob-constructor.html View 1 2 3 2 chunks +0 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/file-constructor.html View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/file-constructor-expected.txt View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/local/blob/resources/hybrid-blob-util.js View 1 2 1 chunk +7 lines, -14 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/local/blob/script-tests/send-data-blob.js View 1 2 3 chunks +6 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/local/blob/send-data-blob-expected.txt View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/resources/post-and-verify-hybrid.cgi View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
D third_party/WebKit/LayoutTests/platform/win/imported/wpt/FileAPI/blob/Blob-constructor-expected.txt View 1 2 1 chunk +0 lines, -66 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/Blob.cpp View 1 2 3 4 3 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/BlobPropertyBag.idl View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/fileapi/File.cpp View 1 2 3 4 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandleTest.cpp View 1 2 3 4 1 chunk +474 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/fetch/FetchFormDataConsumerHandleTest.cpp View 1 2 3 4 1 chunk +481 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.cpp View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobDataTest.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LineEnding.h View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/text/LineEnding.cpp View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
foolip
Should I review this?
4 years, 5 months ago (2016-07-20 17:45:18 UTC) #1
jsbell
On 2016/07/20 17:45:18, foolip wrote: > Should I review this? No rush until we have ...
4 years, 5 months ago (2016-07-20 17:49:09 UTC) #2
jsbell
foolip@ - if you're bored (*grin*) you can review, but I won't land before getting ...
4 years, 5 months ago (2016-07-21 22:06:50 UTC) #11
foolip
4 years, 4 months ago (2016-07-27 18:12:29 UTC) #13
lgtm

https://codereview.chromium.org/2147633002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/files/blob-constructor.html (right):

https://codereview.chromium.org/2147633002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/files/blob-constructor.html:48:
shouldNotThrow("new Blob([], {endings:'illegalValue'})"); // Non-standard
'endings' entry is no longer supported.
I think keeping wpt/FileAPI/blob/Blob-constructor.html as the only negative test
would be just fine, once it's gone from the IDL it's pretty far fetched that it
would somehow regress :)

Powered by Google App Engine
This is Rietveld 408576698