third_party/WebKit/Source/core/fileapi/File.cpp - Issue 2147633002: Remove nonstandard 'endings' option for Blob/File constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fileapi/File.cpp

Issue 2147633002: Remove nonstandard 'endings' option for Blob/File constructor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/BlobPropertyBag.idl ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fileapi/File.cpp

diff --git a/third_party/WebKit/Source/core/fileapi/File.cpp b/third_party/WebKit/Source/core/fileapi/File.cpp

index 5ca1b94385feb6f04a5fa68a49858400638e3bb6..7b3b3447c0e37d43812eae26a8ae80f8aed7e715 100644

--- a/third_party/WebKit/Source/core/fileapi/File.cpp

+++ b/third_party/WebKit/Source/core/fileapi/File.cpp

@@ -122,14 +122,10 @@ File* File::create(

lastModified = static_cast<double>(options.lastModified());

else

lastModified = currentTimeMS();

- ASSERT(options.hasEndings());

- bool normalizeLineEndingsToNative = options.endings() == "native";

- if (normalizeLineEndingsToNative)

- UseCounter::count(context, UseCounter::FileAPINativeLineEndings);

std::unique_ptr<BlobData> blobData = BlobData::create();

blobData->setContentType(options.type().lower());

- populateBlobData(blobData.get(), fileBits, normalizeLineEndingsToNative);

+ populateBlobData(blobData.get(), fileBits);

long long fileSize = blobData->length();

return File::create(fileName, lastModified,

« no previous file with comments | « third_party/WebKit/Source/core/fileapi/BlobPropertyBag.idl ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »