Set the prerender size right and avoid resets

Set the prerender size right and avoid resets

Builds on https://codereview.chromium.org/2259533003
Even if we set a renderer size during prerender, that value gets
overridden on initialization due to two reasons:
- On CVC construction, in setCVC for RWHVAndroid, there is a resize
  no matter what. This changes adds a condition to not resize if it is
  a brand new CVC with zero size.
- In swapCVC in Tab, we actually make an attempt to use the old CVC
  size. In external prerender this should actually use the estimated
  size used previously. This change also does that.

BUG=612218
Committed: https://crrev.com/96ca94bfebcf7697c58650c7f57225019dfc3b9c
Cr-Commit-Position: refs/heads/master@{#405541}

[Yusuf, 2016-07-13 21:50:33]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org, sievers@chromium.org

[Yusuf, 2016-07-13 21:51:05]

sievers@ for RWHVAndroid
dfalcantara@ for the rest

[no sievers, 2016-07-13 21:59:40]

content lgtm

https://codereview.chromium.org/2147543006/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2147543006/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:1699: bool
new_content_view_core = content_view_core
nit: i'd call this !|is_size_initialized| or something

Can you also put the TODO with the other bug id and say that CVC should have a
notion of the request size in some form instead?

[gone, 2016-07-14 17:07:31]

lgtm % daniel's comments

[Yusuf, 2016-07-14 17:23:38]

https://codereview.chromium.org/2147543006/diff/1/content/browser/renderer_ho...
File content/browser/renderer_host/render_widget_host_view_android.cc (right):

https://codereview.chromium.org/2147543006/diff/1/content/browser/renderer_ho...
content/browser/renderer_host/render_widget_host_view_android.cc:1699: bool
new_content_view_core = content_view_core
On 2016/07/13 21:59:40, sievers wrote:
> nit: i'd call this !|is_size_initialized| or something
> 
> Can you also put the TODO with the other bug id and say that CVC should have a
> notion of the request size in some form instead?

Done.

[Yusuf, 2016-07-14 17:23:41]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-07-14 17:23:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2147543006/#ps20001
(title: "siever@'s comments")

[commit-bot: I haz the power, 2016-07-14 17:24:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 17:38:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 17:38:27]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Yusuf, 2016-07-14 18:19:06]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-07-14 18:19:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2147543006/#ps40001
(title: "Fix compile")

[commit-bot: I haz the power, 2016-07-14 18:19:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:38:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:38:04]

Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Yusuf, 2016-07-14 18:46:44]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2016-07-14 18:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
sievers@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2147543006/#ps60001
(title: "Fix compile for real")

[commit-bot: I haz the power, 2016-07-14 18:47:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 19:35:36]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 19:35:45]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 19:38:02]

Description was changed from

==========
Set the prerender size right and avoid resets

Even if we set a renderer size during prerender, that value gets
overridden on initialization due to two reasons:
- On CVC construction, in setCVC for RWHVAndroid, there is a resize
  no matter what. This changes adds a condition to not resize if it is
  a brand new CVC with zero size.
- In swapCVC in Tab, we actually make an attempt to use the old CVC
  size. In external prerender this should actually use the estimated
  size used previously. This change also does that.

BUG=612218
==========

to

==========
Set the prerender size right and avoid resets

Even if we set a renderer size during prerender, that value gets
overridden on initialization due to two reasons:
- On CVC construction, in setCVC for RWHVAndroid, there is a resize
  no matter what. This changes adds a condition to not resize if it is
  a brand new CVC with zero size.
- In swapCVC in Tab, we actually make an attempt to use the old CVC
  size. In external prerender this should actually use the estimated
  size used previously. This change also does that.

BUG=612218

Committed: https://crrev.com/96ca94bfebcf7697c58650c7f57225019dfc3b9c
Cr-Commit-Position: refs/heads/master@{#405541}
==========

[commit-bot: I haz the power, 2016-07-14 19:38:03]

Patchset 4 (id:??) landed as
https://crrev.com/96ca94bfebcf7697c58650c7f57225019dfc3b9c
Cr-Commit-Position: refs/heads/master@{#405541}

[Yusuf, 2017-09-03 06:35:02]

Description was changed from

==========
Set the prerender size right and avoid resets

Even if we set a renderer size during prerender, that value gets
overridden on initialization due to two reasons:
- On CVC construction, in setCVC for RWHVAndroid, there is a resize
  no matter what. This changes adds a condition to not resize if it is
  a brand new CVC with zero size.
- In swapCVC in Tab, we actually make an attempt to use the old CVC
  size. In external prerender this should actually use the estimated
  size used previously. This change also does that.

BUG=612218

Committed: https://crrev.com/96ca94bfebcf7697c58650c7f57225019dfc3b9c
Cr-Commit-Position: refs/heads/master@{#405541}
==========

to

==========
Set the prerender size right and avoid resets

Builds on https://codereview.chromium.org/2259533003
Even if we set a renderer size during prerender, that value gets
overridden on initialization due to two reasons:
- On CVC construction, in setCVC for RWHVAndroid, there is a resize
  no matter what. This changes adds a condition to not resize if it is
  a brand new CVC with zero size.
- In swapCVC in Tab, we actually make an attempt to use the old CVC
  size. In external prerender this should actually use the estimated
  size used previously. This change also does that.

BUG=612218

Committed: https://crrev.com/96ca94bfebcf7697c58650c7f57225019dfc3b9c
Cr-Commit-Position: refs/heads/master@{#405541}
==========