Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3775)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2147543006: Set the prerender size right and avoid resets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile for real Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 414dcbecd1fb554637f68483cebf059444b0a323..966e0363b7f4e9df8967fa684490e223d26a2a59 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -5,11 +5,13 @@
package org.chromium.chrome.browser.tab;
import android.app.Activity;
+import android.app.Application;
import android.content.Context;
import android.content.Intent;
import android.content.res.Resources;
import android.graphics.Bitmap;
import android.graphics.Color;
+import android.graphics.Point;
import android.net.Uri;
import android.os.Build;
import android.os.Bundle;
@@ -68,6 +70,7 @@ import org.chromium.chrome.browser.ntp.NativePageAssassin;
import org.chromium.chrome.browser.ntp.NativePageFactory;
import org.chromium.chrome.browser.omnibox.geo.GeolocationHeader;
import org.chromium.chrome.browser.policy.PolicyAuditor;
+import org.chromium.chrome.browser.prerender.ExternalPrerenderHandler;
import org.chromium.chrome.browser.printing.TabPrinter;
import org.chromium.chrome.browser.profiles.Profile;
import org.chromium.chrome.browser.rlz.RevenueStats;
@@ -2488,17 +2491,26 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
originalHeight = mContentViewCore.getViewportHeightPix();
mContentViewCore.onHide();
}
+
+ if (originalWidth == 0 && originalHeight == 0) {
+ Point size = ExternalPrerenderHandler.estimateContentSize(
+ (Application) getApplicationContext(), false);
+ originalWidth = size.x;
+ originalHeight = size.y;
+ }
+
destroyContentViewCore(deleteOldNativeWebContents);
NativePage previousNativePage = mNativePage;
mNativePage = null;
- setContentViewCore(newContentViewCore);
// Size of the new ContentViewCore is zero at this point. If we don't call onSizeChanged(),
// next onShow() call would send a resize message with the current ContentViewCore size
// (zero) to the renderer process, although the new size will be set soon.
// However, this size fluttering may confuse Blink and rendered result can be broken
// (see http://crbug.com/340987).
- mContentViewCore.onSizeChanged(originalWidth, originalHeight, 0, 0);
- mContentViewCore.onShow();
+ newContentViewCore.onSizeChanged(originalWidth, originalHeight, 0, 0);
+ newContentViewCore.onShow();
+ setContentViewCore(newContentViewCore);
+
mContentViewCore.attachImeAdapter();
// If the URL has already committed (e.g. prerendering), tell process management logic that

Powered by Google App Engine
This is Rietveld 408576698