Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1031)

Issue 2147443004: Retract PipelineBuilder from GrClip::apply (Closed)

Created:
4 years, 5 months ago by robertphillips
Modified:
4 years, 5 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Clean up #

Patch Set 3 : Update to ToT #

Patch Set 4 : More clean up #

Patch Set 5 : Appease some compilers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -68 lines) Patch
M include/gpu/GrClip.h View 1 2 3 4 5 chunks +24 lines, -9 lines 0 comments Download
M src/gpu/GrClip.cpp View 1 2 chunks +12 lines, -6 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 2 3 3 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 1 chunk +5 lines, -6 lines 0 comments Download
M src/gpu/GrDrawContextPriv.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 2 1 chunk +9 lines, -6 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 chunks +10 lines, -8 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 1 2 3 2 chunks +6 lines, -15 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
robertphillips
4 years, 5 months ago (2016-07-13 15:12:46 UTC) #5
bsalomon
lgtm
4 years, 5 months ago (2016-07-13 15:21:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2147443004/80001
4 years, 5 months ago (2016-07-13 16:17:23 UTC) #17
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 16:18:24 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/59cf61ab0384286ebc57ecfb67e2f15ab4846250

Powered by Google App Engine
This is Rietveld 408576698