Don't skip table rows when computing visual rects if the row is the ancestor.

Don't skip table rows when computing visual rects if the row is the ancestor.

BUG=616600
Committed: https://crrev.com/09f0997bf408b508cc56b8a11ca400ecd19c58f8
Cr-Commit-Position: refs/heads/master@{#405917}

[chrishtr, 2016-07-15 21:02:25]

Description was changed from

==========
none


none

BUG=
==========

to

==========
Don't skip table rows when computing visual rects if the row is the ancestor.

BUG=616600
==========

[chrishtr, 2016-07-15 21:02:34]

chrishtr@chromium.org changed reviewers:
+ wkorman@chromium.org

[chrishtr, 2016-07-15 21:02:35]

This bug was introduced by https://codereview.chromium.org/2073563002.

[chrishtr, 2016-07-15 21:02:49]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 21:03:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wkorman, 2016-07-15 21:04:30]

lgtm

https://codereview.chromium.org/2147393003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2147393003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2048: if
(container->isTableRow() && container != ancestor) {
Perhaps add or update the comment to note that we don't skip if the row is both
container and ancestor so as to handle the composited case.

[chrishtr, 2016-07-15 21:09:07]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-15 21:09:08]

https://codereview.chromium.org/2147393003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBox.cpp (right):

https://codereview.chromium.org/2147393003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBox.cpp:2048: if
(container->isTableRow() && container != ancestor) {
On 2016/07/15 at 21:04:30, wkorman wrote:
> Perhaps add or update the comment to note that we don't skip if the row is
both container and ancestor so as to handle the composited case.

Done.

[chrishtr, 2016-07-15 21:09:08]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2147393003/#ps20001
(title: "none")

[commit-bot: I haz the power, 2016-07-15 21:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[chrishtr, 2016-07-15 21:10:50]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2016-07-15 21:12:03]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-15 21:12:03]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2147393003/#ps40001
(title: "none")

[commit-bot: I haz the power, 2016-07-15 21:12:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:41:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 22:41:38]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2016-07-15 22:51:54]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2016-07-15 22:51:54]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2147393003/#ps60001
(title: "none")

[commit-bot: I haz the power, 2016-07-15 22:52:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 01:25:15]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-16 01:27:26]

Description was changed from

==========
Don't skip table rows when computing visual rects if the row is the ancestor.

BUG=616600
==========

to

==========
Don't skip table rows when computing visual rects if the row is the ancestor.

BUG=616600

Committed: https://crrev.com/09f0997bf408b508cc56b8a11ca400ecd19c58f8
Cr-Commit-Position: refs/heads/master@{#405917}
==========

[commit-bot: I haz the power, 2016-07-16 01:27:28]

Patchset 4 (id:??) landed as
https://crrev.com/09f0997bf408b508cc56b8a11ca400ecd19c58f8
Cr-Commit-Position: refs/heads/master@{#405917}