Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 2147393003: Don't skip table rows when computing visual rects if the row is the ancestor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: none Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/composited-table-row-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index bd3dd55b2e8ccb76b136b641254925cee03264ec..6b443a587a2ce3eacddf7d97d75734b7ee46f0d8 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -2044,8 +2044,8 @@ bool LayoutBox::mapToVisualRectInAncestorSpace(const LayoutBoxModelObject* ances
bool filterOrReflectionSkipped;
LayoutObject* container = this->container(ancestor, &ancestorSkipped, &filterOrReflectionSkipped);
LayoutBox* localContainingBlock = containingBlock();
- // Skip table row because cells and rows are in the same coordinate space.
- if (container->isTableRow()) {
+ // Skip table row because cells and rows are in the same coordinate space, except when we're already at the ancestor.
+ if (container->isTableRow() && container != ancestor) {
DCHECK(isTableCell());
localContainingBlock = toLayoutBox(container->parent());
container = container->parent();
« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/composited-table-row-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698