Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2147373002: Merge "Placeholder content direction should not affect INPUT/TEXTAREA direction." to M53. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Merge "Placeholder content direction should not affect INPUT/TEXTAREA direction." to M53. Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG=625739 Review-Url: https://codereview.chromium.org/2145823003 Cr-Commit-Position: refs/heads/master@{#405069} (cherry picked from commit 55f27bb5c4f4f99a2885dc67bd6e448a464505ed) Committed: https://chromium.googlesource.com/chromium/src/+/71e7fb4f9959f570961e6e57830658bafb2d0d4d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
4 years, 5 months ago (2016-07-15 00:22:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
71e7fb4f9959f570961e6e57830658bafb2d0d4d.

Powered by Google App Engine
This is Rietveld 408576698