Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 2145823003: Placeholder content direction should not affect INPUT/TEXTAREA direction. (Closed)

Created:
4 years, 5 months ago by tkent
Modified:
4 years, 5 months ago
Reviewers:
kojii
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Placeholder content direction should not affect INPUT/TEXTAREA direction. Skip -webkit-input-placeholder elements when we compute direction for dir=auto in HTMLElement::directionality. - Using <bdi> for placeholders doesn't work. We want to inherit placeholder direction from the parent element. - Using unicode-bidi CSS property doesn't work. It doesn't affect dir=auto computation. BUG=623270, 625739 Committed: https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed Cr-Commit-Position: refs/heads/master@{#405069}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/text/text-dir-auto-with-placeholder.html View 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/textarea/textarea-dir-auto-with-placeholder.html View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
kojii@, would you review this please?
4 years, 5 months ago (2016-07-13 06:14:13 UTC) #6
kojii
lgtm
4 years, 5 months ago (2016-07-13 07:20:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145823003/40001
4 years, 5 months ago (2016-07-13 07:24:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 5 months ago (2016-07-13 07:29:30 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 07:30:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55f27bb5c4f4f99a2885dc67bd6e448a464505ed
Cr-Commit-Position: refs/heads/master@{#405069}

Powered by Google App Engine
This is Rietveld 408576698