third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 2147343002: DevTools: cleanup treeoutline expand logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 2147343002: DevTools: cleanup treeoutline expand logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

index 8a90167861e000ce05cd0598db3064392ac35312..3af1c231d22316152172f5970420015f36943d8e 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -584,11 +584,9 @@ WebInspector.ObjectPropertyTreeElement.populateWithProperties = function(treeNod

for (var i = 0; i < internalProperties.length; i++) {

internalProperties[i].parentObject = value;

var treeElement = new WebInspector.ObjectPropertyTreeElement(internalProperties[i], linkifier);

- if (internalProperties[i].name === "[[Entries]]") {

- treeElement.setExpandable(true);

- treeElement.expand();

- }

treeNode.appendChild(treeElement);

+ if (internalProperties[i].name === "[[Entries]]")

+ treeElement.expand();

}

if (value && value.type === "function") {

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js » ('j') | no next file with comments »