third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js - Issue 2147343002: DevTools: cleanup treeoutline expand logic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

Issue 2147343002: DevTools: cleanup treeoutline expand logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

index 007e68e654979e77f00907ef094dffaeb84aa7a1..afe101d5d686f25f2261acc4f34d94bff5d0b7d2 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js

@@ -524,8 +524,6 @@ TreeElement.prototype = {

this._childrenListNode.insertBefore(child._childrenListNode, nextSibling);

if (child.selected)

child.select();

- if (child.expanded)

- child.expand();

/**

@@ -883,7 +881,7 @@ TreeElement.prototype = {

expand: function()

{

- if (!this._expandable || (this.expanded && this._children))

+ if (!this._expandable || this.expanded)

return;

// Set this before onpopulate. Since onpopulate can add elements, this makes

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | no next file » | no next file with comments »