DevTools: cleanup treeoutline expand logic

DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=

Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7
Cr-Commit-Position: refs/heads/master@{#407061}

[luoe, 2016-07-19 19:19:38]

Description was changed from

==========
DevTools: cleanup treeoutline expand logic

BUG=
==========

to

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted.  ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property.  This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

[luoe, 2016-07-19 19:19:39]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-07-19 20:15:06]

Description was changed from

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted.  ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property.  This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

to

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

[lushnikov, 2016-07-20 17:05:00]

lgtm, thanks!

[luoe, 2016-07-20 17:15:06]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 17:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 18:54:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 18:54:09]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-07-22 03:01:04]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-07-22 03:02:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 04:36:47]

Description was changed from

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

to

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

[commit-bot: I haz the power, 2016-07-22 04:36:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 04:38:28]

Description was changed from

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=
==========

to

==========
DevTools: cleanup treeoutline expand logic

TreeElement.expand() should not need to check that the element has children and
TreeOutline.insertChild() should not automatically expand a child when it is
inserted. ObjectPropertiesSection.js depended on this logic to automatically
expand the Entries property. This CL updates it so that the Entries property is
added before expanded.

BUG=

Committed: https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7
Cr-Commit-Position: refs/heads/master@{#407061}
==========

[commit-bot: I haz the power, 2016-07-22 04:38:29]

Patchset 1 (id:??) landed as
https://crrev.com/cf5b729f072ba670c7b9966407fb3d47eb2169e7
Cr-Commit-Position: refs/heads/master@{#407061}

[allada, 2016-07-25 21:33:47]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2179783003/ by allada@chromium.org.

The reason for reverting is: [Devtools] Broke header tabs in network tab

B=630971.