Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2147303004:
Exclude XML and dependencies from Bazel build. (Closed)
DescriptionExclude XML and dependencies from Bazel build.
Depends on https://codereview.chromium.org/2150353002
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004
Committed: https://skia.googlesource.com/skia/+/921e48bf233c1ceeb55024c689312e1e4dde3806
Patch Set 1 #
Total comments: 2
Patch Set 2 : Include XML and SVG headers. #Messages
Total messages: 21 (13 generated)
Description was changed from ========== Exclude XML and dependencies from Bazel build. BUG=skia: ========== to ========== Exclude XML and dependencies from Bazel build. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004 ==========
The CQ bit was checked by benjaminwagner@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_6...)
Description was changed from ========== Exclude XML and dependencies from Bazel build. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004 ========== to ========== Exclude XML and dependencies from Bazel build. Depends on https://codereview.chromium.org/2150353002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004 ==========
benjaminwagner@google.com changed reviewers: + fmalita@chromium.org, mtklein@google.com
lgtm https://codereview.chromium.org/2147303004/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/2147303004/diff/1/public.bzl#newcode323 public.bzl:323: exclude = PRIVATE_HDRS_LIST + [ FWIW, we probably don't need to exclude anything beyond private headers. These others don't hurt much, and no one will really be able to use them without compiling the associated .cpp files.
lgtm
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by benjaminwagner@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com, fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/2147303004/#ps40001 (title: "Include XML and SVG headers.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2147303004/diff/1/public.bzl File public.bzl (right): https://codereview.chromium.org/2147303004/diff/1/public.bzl#newcode323 public.bzl:323: exclude = PRIVATE_HDRS_LIST + [ On 2016/07/15 at 16:48:01, mtklein wrote: > FWIW, we probably don't need to exclude anything beyond private headers. These others don't hurt much, and no one will really be able to use them without compiling the associated .cpp files. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)
The CQ bit was checked by benjaminwagner@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Exclude XML and dependencies from Bazel build. Depends on https://codereview.chromium.org/2150353002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004 ========== to ========== Exclude XML and dependencies from Bazel build. Depends on https://codereview.chromium.org/2150353002 BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2147303004 Committed: https://skia.googlesource.com/skia/+/921e48bf233c1ceeb55024c689312e1e4dde3806 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://skia.googlesource.com/skia/+/921e48bf233c1ceeb55024c689312e1e4dde3806 |
