Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: public.bzl

Issue 2147303004: Exclude XML and dependencies from Bazel build. (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Include XML and SVG headers. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public.bzl
diff --git a/public.bzl b/public.bzl
index 9f5c9c2f928197d7f37f1705124bbd8fd335078f..03236c119191e7c489ecfa989a125a7d05547817 100644
--- a/public.bzl
+++ b/public.bzl
@@ -114,7 +114,8 @@ BASE_SRCS_ALL = struct(
# Exclude files that don't compile with the current DEFINES.
"src/gpu/gl/mesa/*", # Requires SK_MESA define.
- "src/svg/parser/*", # Missing SkSVG.h.
+ "src/svg/**/*", # Depends on XML.
+ "src/xml/**/*",
# Conflicting dependencies among Lua versions. See cl/107087297.
"src/utils/SkLua*",
@@ -122,9 +123,6 @@ BASE_SRCS_ALL = struct(
# Not used.
"src/animator/**/*",
"src/views/**/*",
- "src/xml/SkBML_Verbs.h",
- "src/xml/SkBML_XMLParser.cpp",
- "src/xml/SkXMLPullParser.cpp",
# Currently exclude all vulkan specific files
"src/gpu/vk/*",
@@ -326,8 +324,6 @@ BASE_HDRS = struct(
# Not used.
"include/animator/**/*",
"include/views/**/*",
- "include/xml/SkBML_WXMLParser.h",
- "include/xml/SkBML_XMLParser.h",
],
)
@@ -425,6 +421,7 @@ DM_SRCS_ALL = struct(
"tests/skia_test.cpp", # Old main.
"tests/SkpSkGrTest.cpp", # Alternate main.
"tests/SkSLErrorTest.cpp", # Excluded along with Vulkan.
+ "tests/SVGDeviceTest.cpp",
"tools/gpu/gl/angle/*",
"tools/gpu/gl/command_buffer/*",
"tools/gpu/gl/egl/*",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698