Don't call into JS from within stack trace generation

Don't call into JS from within stack trace generation

Calling into JS from stack trace generation becomes an issue during
stack overflows: we'd detect a stack overflow, attempt to create an
exception, call into JS, detect a stack overflow, and repeat.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/4fbffba4da4bbf7873f479e7afe7d9f0114f9b8b
Cr-Commit-Position: refs/heads/master@{#37837}

[jgruber, 2016-07-14 09:52:42]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 09:52:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 10:16:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 10:16:09]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-07-15 11:36:09]

https://codereview.chromium.org/2147193002/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/2147193002/diff/1/src/objects.cc#newcode12857
src/objects.cc:12857: isolate->factory()->source_url_string())
This should simply call Accessors::ScriptSourceUrlGetter.

Can we get rid of this detour and just get script->source_url()?

Same below with script->name().

[jgruber, 2016-07-18 11:56:32]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 11:56:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 12:18:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 12:18:40]

Dry run: This issue passed the CQ dry run.

[jgruber, 2016-07-18 12:34:40]

PTAL, this time with the real commit.

[Yang, 2016-07-18 12:36:18]

On 2016/07/18 12:34:40, jgruber wrote:
> PTAL, this time with the real commit.

lgtm.

[jgruber, 2016-07-18 12:52:09]

The CQ bit was checked by jgruber@chromium.org

[commit-bot: I haz the power, 2016-07-18 12:52:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 12:54:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-18 12:55:00]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 12:56:30]

Description was changed from

==========
Don't call into JS from within stack trace generation

Calling into JS from stack trace generation becomes an issue during
stack overflows: we'd detect a stack overflow, attempt to create an
exception, call into JS, detect a stack overflow, and repeat.

R=yangguo@chromium.org
BUG=
==========

to

==========
Don't call into JS from within stack trace generation

Calling into JS from stack trace generation becomes an issue during
stack overflows: we'd detect a stack overflow, attempt to create an
exception, call into JS, detect a stack overflow, and repeat.

R=yangguo@chromium.org
BUG=

Committed: https://crrev.com/4fbffba4da4bbf7873f479e7afe7d9f0114f9b8b
Cr-Commit-Position: refs/heads/master@{#37837}
==========

[commit-bot: I haz the power, 2016-07-18 12:56:31]

Patchset 2 (id:??) landed as
https://crrev.com/4fbffba4da4bbf7873f479e7afe7d9f0114f9b8b
Cr-Commit-Position: refs/heads/master@{#37837}