src/js/messages.js - Issue 2147193002: Don't call into JS from within stack trace generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/messages.js

Issue 2147193002: Don't call into JS from within stack trace generation (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Just access the script itself, it's what the accessors do Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/messages.js

diff --git a/src/js/messages.js b/src/js/messages.js

index d01f3efdf4ac326327534e29b7346ca0fb9561f3..934d44f73d1b5b07c475e6240f35edcb06e5a6dd 100644

--- a/src/js/messages.js

+++ b/src/js/messages.js

@@ -246,6 +246,7 @@ function ScriptLocationFromPosition(position,

* deprecated //@ sourceURL comment otherwise.

function ScriptNameOrSourceURL() {

+ // Keep in sync with Script::GetNameOrSourceURL.

if (this.source_url) return this.source_url;

return this.name;

}

« no previous file with comments | « src/isolate.cc ('k') | src/objects.cc » ('j') | no next file with comments »