Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/flags_ui/feature_entry.h

Issue 2146903002: Clean-up the code for default variations in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS test crash fix? #2 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/feature_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/flags_ui/feature_entry.h
diff --git a/components/flags_ui/feature_entry.h b/components/flags_ui/feature_entry.h
index a3930fd2e13e477bf55cf433951c3d546caf01f0..5c44bc3334f3e16e236faae040cc7042e42aa565 100644
--- a/components/flags_ui/feature_entry.h
+++ b/components/flags_ui/feature_entry.h
@@ -50,10 +50,12 @@ struct FeatureEntry {
// Corresponds to a base::Feature and additional options [O_1, ..., O_n]
// that specify variation parameters. Each of the options can specify a set
- // of variation parameters. The entry will have n+2 states: Default,
- // Enabled: V_1, ..., Enabled: V_n, Disabled. When not specified or set to
- // Default, the normal default values of the feature and of the parameters
- // are used.
+ // of variation parameters. The entry will have n+3 states: Default,
+ // Enabled, Enabled V_1, ..., Enabled: V_n, Disabled. When set to Default,
+ // the normal default values of the feature and of the parameters are used
+ // (possibly passed from the server in a trial config). When set to Enabled,
+ // the feature is overriden to be enabled and empty set of parameters is
+ // used boiling down to the default behavior in the code.
FEATURE_WITH_VARIATIONS_VALUE,
};
« no previous file with comments | « chrome/browser/about_flags.cc ('k') | components/flags_ui/feature_entry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698