Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/about_flags.cc

Issue 2146903002: Clean-up the code for default variations in chrome://flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: iOS test crash fix? #2 Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/about_flags.cc
diff --git a/chrome/browser/about_flags.cc b/chrome/browser/about_flags.cc
index 62686c60dfb5e3458547ad0a388a02e017cb6d9a..52ff30d8df36a778eef41a659ac93f4d328fd0f7 100644
--- a/chrome/browser/about_flags.cc
+++ b/chrome/browser/about_flags.cc
@@ -513,7 +513,6 @@ const FeatureEntry::Choice kNtpSwitchToExistingTabChoices[] = {
#endif // defined(OS_ANDROID)
#if defined(OS_ANDROID)
-const FeatureEntry::FeatureParam kNTPSnippetsFeatureVariationDefault[] = {};
const FeatureEntry::FeatureParam kNTPSnippetsFeatureVariationOnlyPersonal[] = {
{"fetching_personalization", "personal"},
{"fetching_host_restrict", "off"},
@@ -529,10 +528,7 @@ const FeatureEntry::FeatureParam
{"fetching_host_restrict", "on"},
};
-// TODO(jkrcal) allow for nullptr instead of the empty array.
const FeatureEntry::FeatureVariation kNTPSnippetsFeatureVariations[] = {
- {"", kNTPSnippetsFeatureVariationDefault,
- 0},
{"only personalized", kNTPSnippetsFeatureVariationOnlyPersonal,
arraysize(kNTPSnippetsFeatureVariationOnlyPersonal)},
{"only from most visited sites",
« no previous file with comments | « no previous file | components/flags_ui/feature_entry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698