Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2146783003: [Android] Add option to run perf tests in platform mode. (Closed)

Created:
4 years, 5 months ago by rnephew (Reviews Here)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

[Android] Add option to run perf tests in platform mode. BUG=615157 Committed: https://chromium.googlesource.com/chromium/tools/build/+/dfdf1345605f32aad5c842247e94e130c274154b

Patch Set 1 #

Total comments: 2

Patch Set 2 : johns nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -19 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 5 chunks +11 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 2 chunks +6 lines, -1 line 0 comments Download
A + scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json View 6 chunks +13 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/steps.py View 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/android/perf.py View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
rnephew (Reviews Here)
Note: This does not turn it on for any perf bots, it just adds the ...
4 years, 5 months ago (2016-07-13 15:56:33 UTC) #2
dtu
What's platform mode?
4 years, 5 months ago (2016-07-13 18:04:01 UTC) #3
jbudorick
lgtm w/ nit @dtu: "platform mode" is the somewhat-nondescript name for the rewrite of the ...
4 years, 5 months ago (2016-07-13 18:06:13 UTC) #4
rnephew (Reviews Here)
https://codereview.chromium.org/2146783003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2146783003/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode646 scripts/slave/recipe_modules/chromium_android/api.py:646: enable_platform_mode: If set, will run in new platform mode ...
4 years, 5 months ago (2016-07-13 20:45:54 UTC) #5
rnephew (Reviews Here)
ping dtu@ I'd like to get your ok before moving ahead on this.
4 years, 5 months ago (2016-07-19 15:27:05 UTC) #6
dtu
lgtm
4 years, 5 months ago (2016-07-19 23:57:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146783003/20001
4 years, 5 months ago (2016-07-20 01:21:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Build%20Presubmit/builds/6300)
4 years, 5 months ago (2016-07-20 01:30:21 UTC) #12
rnephew (Reviews Here)
4 years, 5 months ago (2016-07-20 16:57:29 UTC) #14
rnephew (Reviews Here)
On 2016/07/20 16:57:29, rnephew (Reviews Here) wrote: MIssing owners for steps.py; added 2.
4 years, 5 months ago (2016-07-20 16:57:47 UTC) #15
rnephew (Reviews Here)
4 years, 5 months ago (2016-07-20 17:03:41 UTC) #17
rnephew (Reviews Here)
4 years, 5 months ago (2016-07-20 17:03:43 UTC) #18
ghost stip (do not use)
surprised there aren't more expectation changes but lgtm
4 years, 5 months ago (2016-07-20 17:09:06 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146783003/20001
4 years, 5 months ago (2016-07-20 17:10:02 UTC) #21
rnephew (Reviews Here)
On 2016/07/20 17:09:06, stip wrote: > surprised there aren't more expectation changes but lgtm This ...
4 years, 5 months ago (2016-07-20 17:10:55 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:15:16 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/dfdf1345605f32aad5c8...

Powered by Google App Engine
This is Rietveld 408576698