scripts/slave/recipe_modules/chromium_tests/steps.py - Issue 2146783003: [Android] Add option to run perf tests in platform mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/steps.py

Issue 2146783003: [Android] Add option to run perf tests in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: johns nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_android/example.expected/enable_platform_mode_basic.json ('k') | scripts/slave/recipes/android/perf.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/steps.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/steps.py b/scripts/slave/recipe_modules/chromium_tests/steps.py

index 11c84745b88990258e1ee858be65890bcef9b439..6301fb0e8c179cc2577801266a60817cff8387d0 100644

--- a/scripts/slave/recipe_modules/chromium_tests/steps.py

+++ b/scripts/slave/recipe_modules/chromium_tests/steps.py

@@ -535,11 +535,12 @@ def generate_script(api, chromium_tests_api, mastername, buildername, test_spec,

class DynamicPerfTests(Test):

def __init__(self, perf_id, platform, target_bits, max_battery_temp=None,

num_device_shards=1, num_host_shards=1, shard_index=0,

- override_browser_name=None):

+ override_browser_name=None, enable_platform_mode=False):

self._perf_id = perf_id

self._platform = platform

self._target_bits = target_bits

+ self._enable_platform_mode = enable_platform_mode

self._max_battery_temp = max_battery_temp

self._num_host_shards = num_host_shards

self._num_device_shards = num_device_shards

@@ -596,7 +597,8 @@ class DynamicPerfTests(Test):

perf_id=self._perf_id,

chartjson_file=True,

max_battery_temp=self._max_battery_temp,

- known_devices_file=api.chromium_android.known_devices_file)

+ known_devices_file=api.chromium_android.known_devices_file,

+ enable_platform_mode=self._enable_platform_mode)

def _run_serially(self, api, tests):

failure = None