Issue 2146713004: More changes to use #ifndef PRODUCT ... #endif explicitly instead of relying on compiler magic.

Issue 2146713004: More changes to use #ifndef PRODUCT ... #endif explicitly instead of relying on compiler magic. (Closed)

Created:
4 years, 5 months ago by siva

Modified:
4 years, 5 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More changes to use #ifndef PRODUCT ... #endif explicitly instead of relying on compiler magic. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/aaa0867567f19de61a205b4cce0808cdc102f349

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+126 lines, -46 lines)			Patch
M	runtime/lib/developer.cc	View	4 chunks	+18 lines, -0 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	2 chunks	+65 lines, -42 lines	0 comments	Download
M	runtime/vm/flags.h	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	runtime/vm/flags.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/gc_marker.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	9 chunks	+12 lines, -3 lines	0 comments	Download
M	runtime/vm/metrics.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/metrics.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/scavenger.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View	4 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/tags.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/tags.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

siva

4 years, 5 months ago (2016-07-14 18:13:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aaa0867567f19de61a205b4cce0808cdc102f349 (presubmit successful).