runtime/vm/metrics.cc - Issue 2146713004: More changes to use #ifndef PRODUCT ... #endif explicitly instead of relying on compiler magic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/metrics.cc

Issue 2146713004: More changes to use #ifndef PRODUCT ... #endif explicitly instead of relying on compiler magic. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/metrics.cc

diff --git a/runtime/vm/metrics.cc b/runtime/vm/metrics.cc

index 581ed826748566b5c2efa642b51ca371f5110f36..137042e124f974f4936721da98c1a9fb3a73bfae 100644

--- a/runtime/vm/metrics.cc

+++ b/runtime/vm/metrics.cc

@@ -67,6 +67,7 @@ Metric::~Metric() {

}

+#ifndef PRODUCT

static const char* UnitString(intptr_t unit) {

switch (unit) {

case Metric::kCounter: return "counter";

@@ -97,6 +98,7 @@ void Metric::PrintJSON(JSONStream* stream) {

double value_as_double = static_cast<double>(Value());

obj.AddProperty("value", value_as_double);

}

+#endif // !PRODUCT

char* Metric::ValueToString(int64_t value, Unit unit) {

« no previous file with comments | « runtime/vm/metrics.h ('k') | runtime/vm/object_store.h » ('j') | no next file with comments »