Issue 214663009: ES6: Promise.prototype.then should use callable for its arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 214663009: ES6: Promise.prototype.then should use callable for its arguments (Closed)

Created:
6 years, 9 months ago by arv (Not doing code reviews)

Modified:
6 years, 6 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ES6: Promise.prototype.then should use callable for its arguments http://people.mozilla.org/~jorendorff/es6-draft.html#sec-promise.prototype.then We used to use the default id handlers if the argument was null or undefined. The spec says that we should use IsCallable instead. BUG=None LOG=Y R=rossberg@chromium.org

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -4 lines)			Patch
	M	src/promise.js	View		1 chunk	+2 lines, -4 lines	1 comment	Download
	M	test/mjsunit/es6/promises.js	View		2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

PTAL https://codereview.chromium.org/214663009/diff/1/src/promise.js File src/promise.js (right): https://codereview.chromium.org/214663009/diff/1/src/promise.js#newcode203 src/promise.js:203: if (typeof onResolve !== 'function') onResolve = PromiseIdResolveHandler; ...

6 years, 9 months ago (2014-03-27 21:10:46 UTC) #1

rossberg

Please see Yutaka's pending CL: https://codereview.chromium.org/180723011/ It is on hold until https://bugs.ecmascript.org/show_bug.cgi?id=2566 gets resolved.

6 years, 9 months ago (2014-03-28 07:38:31 UTC) #2

rossberg

6 years, 7 months ago (2014-05-07 09:22:13 UTC) #3

On 2014/03/28 07:38:31, rossberg wrote:
> Please see Yutaka's pending CL: https://codereview.chromium.org/180723011/
> 
> It is on hold until https://bugs.ecmascript.org/show_bug.cgi?id=2566 gets
> resolved.

Yutaka's CL has landed, so we can close this one.

Expand Messages | Collapse Messages