src/promise.js - Issue 214663009: ES6: Promise.prototype.then should use callable for its arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/promise.js

Issue 214663009: ES6: Promise.prototype.then should use callable for its arguments (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/promise.js

diff --git a/src/promise.js b/src/promise.js

index 50f91ae0ba3443f4b9113b6395e68af396bb71a8..29f641d55d6a8ff3343d38e33b348d05607f4640 100644

--- a/src/promise.js

+++ b/src/promise.js

@@ -200,10 +200,8 @@ function PromiseHandle(value, handler, deferred) {

// Multi-unwrapped chaining with thenable coercion.

function PromiseThen(onResolve, onReject) {

- onResolve =

- IS_NULL_OR_UNDEFINED(onResolve) ? PromiseIdResolveHandler : onResolve;

- onReject =

- IS_NULL_OR_UNDEFINED(onReject) ? PromiseIdRejectHandler : onReject;

+ if (typeof onResolve !== 'function') onResolve = PromiseIdResolveHandler;

arv (Not doing code reviews) 2014/03/27 21:10:46 Maybe we should add an IsCallable macro?

+ if (typeof onReject !== 'function') onReject = PromiseIdRejectHandler;

var that = this;

var constructor = this.constructor;

return %_CallFunction(

« no previous file with comments | « no previous file | test/mjsunit/es6/promises.js » ('j') | no next file with comments »