|
|
Chromium Code Reviews
DescriptionRemove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
Committed: https://crrev.com/a898d221e7a213f2b011c1751276a55da6f5a0c4
Cr-Commit-Position: refs/heads/master@{#404847}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
TBR=dimu@google.com
==========
to
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
==========
fmalita@chromium.org changed reviewers: + dpranke@chromium.org, thakis@chromium.org - dimu@google.com
lgtm dimu, how come https://codereview.chromium.org/2136353002/ was landed without review?
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/07/12 17:47:29, Nico wrote: > lgtm > > dimu, how come https://codereview.chromium.org/2136353002/ was landed without > review? Sry I was having some authentication issues committing to src.git yesterday, and I created several CLs to retry and it turned out that I submitted the wrong one. The real reviewed CL is https://codereview.chromium.org/2136143002/patch/20001/30001
On 2016/07/12 18:00:16, dimu wrote: > On 2016/07/12 17:47:29, Nico wrote: > > lgtm > > > > dimu, how come https://codereview.chromium.org/2136353002/ was landed without > > review? > > Sry I was having some authentication issues committing to src.git yesterday, and > I created several CLs to retry and it turned out that I submitted the wrong one. > > The real reviewed CL is > https://codereview.chromium.org/2136143002/patch/20001/30001 Ah cool. What I'd recommend to do in this case is to say "Reviewed at <link>" in the newly-uploaded CL.
On 2016/07/12 18:01:19, Nico wrote: > On 2016/07/12 18:00:16, dimu wrote: > > On 2016/07/12 17:47:29, Nico wrote: > > > lgtm > > > > > > dimu, how come https://codereview.chromium.org/2136353002/ was landed > without > > > review? > > > > Sry I was having some authentication issues committing to src.git yesterday, > and > > I created several CLs to retry and it turned out that I submitted the wrong > one. > > > > The real reviewed CL is > > https://codereview.chromium.org/2136143002/patch/20001/30001 > > Ah cool. What I'd recommend to do in this case is to say "Reviewed at <link>" in > the newly-uploaded CL. sure I've just modified the description of the uploaded CL. Thanks!
The CQ bit was unchecked by fmalita@chromium.org
Description was changed from
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
==========
to
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
==========
The CQ bit was checked by fmalita@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
==========
to
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
==========
to
==========
Remove trailing garbage from bisect-builds.py
File "tools/bisect-builds.py", line 897
return m.group(1)]
^
SyntaxError: invalid syntax
(introduced in http://crrev.com/2136353002)
R=dpranke@chromium.org,thakis@chromium.org
NOTRY=true
Committed: https://crrev.com/a898d221e7a213f2b011c1751276a55da6f5a0c4
Cr-Commit-Position: refs/heads/master@{#404847}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/a898d221e7a213f2b011c1751276a55da6f5a0c4 Cr-Commit-Position: refs/heads/master@{#404847} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
