Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2146583002: Remove trailing garbage from bisect-builds.py (Closed)

Created:
4 years, 5 months ago by f(malita)
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trailing garbage from bisect-builds.py File "tools/bisect-builds.py", line 897 return m.group(1)] ^ SyntaxError: invalid syntax (introduced in http://crrev.com/2136353002) R=dpranke@chromium.org,thakis@chromium.org NOTRY=true Committed: https://crrev.com/a898d221e7a213f2b011c1751276a55da6f5a0c4 Cr-Commit-Position: refs/heads/master@{#404847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/bisect-builds.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
f(malita)
4 years, 5 months ago (2016-07-12 17:41:27 UTC) #3
Nico
lgtm dimu, how come https://codereview.chromium.org/2136353002/ was landed without review?
4 years, 5 months ago (2016-07-12 17:47:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146583002/1
4 years, 5 months ago (2016-07-12 17:48:59 UTC) #6
dimu
On 2016/07/12 17:47:29, Nico wrote: > lgtm > > dimu, how come https://codereview.chromium.org/2136353002/ was landed ...
4 years, 5 months ago (2016-07-12 18:00:16 UTC) #7
Nico
On 2016/07/12 18:00:16, dimu wrote: > On 2016/07/12 17:47:29, Nico wrote: > > lgtm > ...
4 years, 5 months ago (2016-07-12 18:01:19 UTC) #8
dimu
On 2016/07/12 18:01:19, Nico wrote: > On 2016/07/12 18:00:16, dimu wrote: > > On 2016/07/12 ...
4 years, 5 months ago (2016-07-12 18:10:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146583002/1
4 years, 5 months ago (2016-07-12 21:04:37 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-12 22:29:18 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 22:31:36 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a898d221e7a213f2b011c1751276a55da6f5a0c4
Cr-Commit-Position: refs/heads/master@{#404847}

Powered by Google App Engine
This is Rietveld 408576698