Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Side by Side Diff: tools/bisect-builds.py

Issue 2146583002: Remove trailing garbage from bisect-builds.py (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Snapshot Build Bisect Tool 6 """Snapshot Build Bisect Tool
7 7
8 This script bisects a snapshot archive using binary search. It starts at 8 This script bisects a snapshot archive using binary search. It starts at
9 a bad revision (it will try to guess HEAD) and asks for a last known-good 9 a bad revision (it will try to guess HEAD) and asks for a last known-good
10 revision. It will then binary search across this revision range by downloading, 10 revision. It will then binary search across this revision range by downloading,
(...skipping 876 matching lines...) Expand 10 before | Expand all | Expand 10 after
887 887
888 888
889 def GetBlinkDEPSRevisionForChromiumRevision(self, rev): 889 def GetBlinkDEPSRevisionForChromiumRevision(self, rev):
890 """Returns the blink revision that was in REVISIONS file at 890 """Returns the blink revision that was in REVISIONS file at
891 chromium revision |rev|.""" 891 chromium revision |rev|."""
892 892
893 def _GetBlinkRev(url, blink_re): 893 def _GetBlinkRev(url, blink_re):
894 m = blink_re.search(url.read()) 894 m = blink_re.search(url.read())
895 url.close() 895 url.close()
896 if m: 896 if m:
897 return m.group(1)] 897 return m.group(1)
898 898
899 url = urllib.urlopen(DEPS_FILE % GetGitHashFromSVNRevision(rev)) 899 url = urllib.urlopen(DEPS_FILE % GetGitHashFromSVNRevision(rev))
900 if url.getcode() == 200: 900 if url.getcode() == 200:
901 blink_re = re.compile(r'webkit_revision\D*\d+;\D*\d+;(\w+)') 901 blink_re = re.compile(r'webkit_revision\D*\d+;\D*\d+;(\w+)')
902 blink_git_sha = _GetBlinkRev(url, blink_re) 902 blink_git_sha = _GetBlinkRev(url, blink_re)
903 return self.GetSVNRevisionFromGitHash(blink_git_sha, 'blink') 903 return self.GetSVNRevisionFromGitHash(blink_git_sha, 'blink')
904 raise Exception('Could not get Blink revision for Chromium rev %d' % rev) 904 raise Exception('Could not get Blink revision for Chromium rev %d' % rev)
905 905
906 906
907 def GetBlinkRevisionForChromiumRevision(context, rev): 907 def GetBlinkRevisionForChromiumRevision(context, rev):
(...skipping 255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 if min_blink_rev != max_blink_rev: 1163 if min_blink_rev != max_blink_rev:
1164 print ('NOTE: There is a Blink roll in the range, ' 1164 print ('NOTE: There is a Blink roll in the range, '
1165 'you might also want to do a Blink bisect.') 1165 'you might also want to do a Blink bisect.')
1166 1166
1167 print 'CHANGELOG URL:' 1167 print 'CHANGELOG URL:'
1168 PrintChangeLog(min_chromium_rev, max_chromium_rev) 1168 PrintChangeLog(min_chromium_rev, max_chromium_rev)
1169 1169
1170 1170
1171 if __name__ == '__main__': 1171 if __name__ == '__main__':
1172 sys.exit(main()) 1172 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698