Expose effective connection type to Cronet

components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index 17b5b7dbcb56453e67707b5ad9101cc8846b1c55..6dbca4f6d6666a1dfeb80720e08cc49a7bb83c2f 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -899,6 +899,14 @@ public abstract class CronetEngine {
     public abstract void setRequestFinishedListenerExecutor(Executor executor);
 
     /**
+     * Returns the effective connection type computed by network quality
+     * estimator. The return value is an enum specified in
+     * NetworkQualityEstimator::EffectiveConnectionType in
+     * //net/nqe/network_quality_estimator.h.

[pauljensen, 2016/07/18 13:42:17]

I think there are a few issues here:
1. It's not clear to me what "effective connection type" is.  It sounds like
we're trying to replace Android's ConnectivityManager which seems like a very
hard thing to do.
2. I don't think readers of this API know what "network quality estimator" is.
3. We don't want to be referencing C++ code from Java code if at all possible.
4. I don't think users will know what "//net/nqe/network_quality_estimator.h"
is.

[tbansal1, 2016/08/01 20:58:09]

Done.

+     */
+    public abstract int getEffectiveConnectionType();
+
+    /**
      * Enables the network quality estimator, which collects and reports
      * measurements of round trip time (RTT) and downstream throughput at
      * various layers of the network stack. After enabling the estimator,