Expose effective connection type to Cronet

components/cronet/android/api/src/org/chromium/net/CronetEngine.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net;
 
 import android.annotation.SuppressLint;
 import android.content.Context;
 import android.net.http.HttpResponseCache;
 import android.support.annotation.IntDef;
@@ skipping 881 matching lines @@
      *             that do not provide an executor.
      * TODO(tbansal):  http://crbug.com/618034 Remove this API. In short term,
      * once all Cronet embedders supply a valid executor with
      * NetworkQualityRTTListener, update the above comment to reflect that
      * {@link executor} is only used to notify RequestFinishedListeners.
      * @hide as it's a prototype.
      */
     public abstract void setRequestFinishedListenerExecutor(Executor executor);
 
     /**
+     * Returns the effective connection type computed by network quality
+     * estimator. The return value is an enum specified in
+     * NetworkQualityEstimator::EffectiveConnectionType in
+     * //net/nqe/network_quality_estimator.h.

[pauljensen, 2016/07/18 13:42:17]

I think there are a few issues here:
1. It's not clear to me what "effective connection type" is.  It sounds like
we're trying to replace Android's ConnectivityManager which seems like a very
hard thing to do.
2. I don't think readers of this API know what "network quality estimator" is.
3. We don't want to be referencing C++ code from Java code if at all possible.
4. I don't think users will know what "//net/nqe/network_quality_estimator.h"
is.

[tbansal1, 2016/08/01 20:58:09]

Done.

+     */
+    public abstract int getEffectiveConnectionType();
+
+    /**
      * Enables the network quality estimator, which collects and reports
      * measurements of round trip time (RTT) and downstream throughput at
      * various layers of the network stack. After enabling the estimator,
      * listeners of RTT and throughput can be added with
      * {@link #addRttListener} and {@link #addThroughputListener} and
      * removed with {@link #removeRttListener} and
      * {@link #removeThroughputListener}. The estimator uses memory and CPU
      * only when enabled.
      * @param executor an executor that will be used to notified all
      *            added RTT and throughput listeners.
@@ skipping 289 matching lines @@
      * @hide as it's a prototype.
      */
     public interface RequestFinishedListener {
         /**
          * Invoked with request info.
          * @param requestInfo {@link UrlRequestInfo} for finished request.
          */
         void onRequestFinished(UrlRequestInfo requestInfo);
     }
 }