Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 2146553006: [turbofan] Don't connect regular Phis into the effect chain. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Don't connect regular Phis into the effect chain. When the effect control linearizer tries to clone a branch, it accidentially connected regular Phis into the effect chain. R=jarin@chromium.org Committed: https://crrev.com/dae6320d1bc5bc3d618215ffe85ad12f917969a9 Cr-Commit-Position: refs/heads/master@{#37698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/compiler/effect-control-linearizer.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-13 05:01:15 UTC) #1
Benedikt Meurer
Jaro: PTAL Enrico: FYI
4 years, 5 months ago (2016-07-13 05:02:14 UTC) #4
Jarin
lgtm
4 years, 5 months ago (2016-07-13 05:11:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146553006/1
4 years, 5 months ago (2016-07-13 05:11:38 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 05:21:29 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dae6320d1bc5bc3d618215ffe85ad12f917969a9 Cr-Commit-Position: refs/heads/master@{#37698}
4 years, 5 months ago (2016-07-13 05:21:51 UTC) #11
epertoso
4 years, 5 months ago (2016-07-13 08:07:47 UTC) #12
Message was sent while issue was closed.
On 2016/07/13 at 05:02:14, bmeurer wrote:
> Jaro: PTAL
> Enrico: FYI

Thanks for fixing this.

Powered by Google App Engine
This is Rietveld 408576698