Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/compiler/effect-control-linearizer.cc

Issue 2146553006: [turbofan] Don't connect regular Phis into the effect chain. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/effect-control-linearizer.cc
diff --git a/src/compiler/effect-control-linearizer.cc b/src/compiler/effect-control-linearizer.cc
index 9e35e51955e908c026f0c2cda34b17cc9dd4fd08..aeb5926759fc7a45a1703965a5643ba215e66c79 100644
--- a/src/compiler/effect-control-linearizer.cc
+++ b/src/compiler/effect-control-linearizer.cc
@@ -276,8 +276,10 @@ void TryCloneBranch(Node* node, BasicBlock* block, Graph* graph,
edge.UpdateTo((control == matcher.IfTrue()) ? phi_true : phi_false);
}
}
- true_block_data->current_effect = phi_true;
- false_block_data->current_effect = phi_false;
+ if (phi->opcode() == IrOpcode::kEffectPhi) {
+ true_block_data->current_effect = phi_true;
+ false_block_data->current_effect = phi_false;
+ }
phi->Kill();
}
// Fix up IfTrue and IfFalse and kill all dead nodes.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698