Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2146523004: Make full-form autofill the only implementation on iOS. (Closed)

Created:
4 years, 5 months ago by Justin Donnelly
Modified:
4 years, 5 months ago
CC:
chromium-reviews, rouslan+autofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make full-form autofill the only implementation on iOS. Removes support for the old field-at-a-time autofill on iOS. Full-form has been enabled for all iOS users for many months. Corresponding internal change: https://chromereviews.googleplex.com/470777015 BUG=504644, 268279 Committed: https://crrev.com/7117eadc2c598e53d61945f9d93f4ff5fcec205a Cr-Commit-Position: refs/heads/master@{#405237}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -171 lines) Patch
M components/autofill.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D components/autofill/core/browser/autofill_field_trial_ios.h View 1 chunk +0 lines, -28 lines 0 comments Download
D components/autofill/core/browser/autofill_field_trial_ios.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/autofill/core/browser/autofill_manager_unittest.cc View 2 chunks +2 lines, -24 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/autofill/ios/browser/js_autofill_manager.h View 1 chunk +1 line, -10 lines 0 comments Download
M components/autofill/ios/browser/js_autofill_manager.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M components/autofill/ios/browser/resources/autofill_controller.js View 2 chunks +1 line, -30 lines 0 comments Download
M ios/chrome/browser/about_flags.mm View 2 chunks +0 lines, -9 lines 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller.mm View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Justin Donnelly
mathp: please review the entire CL rohitrao: about_flags.mm OWNERS approval
4 years, 5 months ago (2016-07-12 22:16:18 UTC) #3
rohitrao (ping after 24h)
lgtm
4 years, 5 months ago (2016-07-12 22:19:22 UTC) #4
Mathieu
lgtm, what's not to like in a red CL?!
4 years, 5 months ago (2016-07-13 16:28:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146523004/1
4 years, 5 months ago (2016-07-13 18:50:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 19:51:24 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 19:52:05 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 19:55:10 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7117eadc2c598e53d61945f9d93f4ff5fcec205a
Cr-Commit-Position: refs/heads/master@{#405237}

Powered by Google App Engine
This is Rietveld 408576698