ios/chrome/browser/about_flags.mm - Issue 2146523004: Make full-form autofill the only implementation on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/about_flags.mm

Issue 2146523004: Make full-form autofill the only implementation on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/ios/browser/resources/autofill_controller.js ('k') | ios/chrome/browser/autofill/form_suggestion_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/about_flags.mm

diff --git a/ios/chrome/browser/about_flags.mm b/ios/chrome/browser/about_flags.mm

index 9f19234497a032698194b82d2a68c9a7c29c703d..79a462836cbd95abbbf163d4add91629739254ec 100644

--- a/ios/chrome/browser/about_flags.mm

+++ b/ios/chrome/browser/about_flags.mm

@@ -19,7 +19,6 @@

#include "base/strings/stringprintf.h"

#include "base/strings/sys_string_conversions.h"

#include "base/sys_info.h"

-#include "components/autofill/core/common/autofill_switches.h"

#include "components/dom_distiller/core/dom_distiller_switches.h"

#include "components/flags_ui/feature_entry.h"

#include "components/flags_ui/feature_entry_macros.h"

@@ -144,14 +143,6 @@ void AppendSwitchesFromExperimentalSettings(base::CommandLine* command_line) {

if ([defaults boolForKey:@"EnableCredentialManagement"])

command_line->AppendSwitch(switches::kEnableCredentialManagerAPI);

- // Populate command line flags from FullFormAutofill.

- NSString* fullFormAutofillValue = [defaults stringForKey:@"FullFormAutofill"];

- if ([fullFormAutofillValue isEqualToString:@"Enabled"]) {

- command_line->AppendSwitch(autofill::switches::kEnableFullFormAutofillIOS);

- } else if ([fullFormAutofillValue isEqualToString:@"Disabled"]) {

- command_line->AppendSwitch(autofill::switches::kDisableFullFormAutofillIOS);

- }

NSString* autoReloadEnabledValue =

[defaults stringForKey:@"AutoReloadEnabled"];

if ([autoReloadEnabledValue isEqualToString:@"Enabled"]) {