Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2146523003: shutil recipe_module: port chromium_utils rmtree implementation. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/recipes-py@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix license #

Patch Set 3 : with flag #

Patch Set 4 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -8 lines) Patch
M recipe_modules/shutil/api.py View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M recipe_modules/shutil/example.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M recipe_modules/shutil/example.expected/basic.json View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
A + recipe_modules/shutil/resources/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A recipe_modules/shutil/resources/rmtree.py View 1 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
tandrii(chromium)
4 years, 5 months ago (2016-07-12 19:45:29 UTC) #1
martiniss
lgtm
4 years, 5 months ago (2016-07-12 19:58:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146523003/1
4 years, 5 months ago (2016-07-12 20:09:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Recipes-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Recipes-py%20Presubmit/builds/347)
4 years, 5 months ago (2016-07-12 20:13:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146523003/20001
4 years, 5 months ago (2016-07-12 20:14:15 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://github.com/luci/recipes-py/commit/774c69370e740a8a5c85dce90f88a2bbd11911f5
4 years, 5 months ago (2016-07-12 20:16:51 UTC) #17
tandrii(chromium)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2141223002/ by tandrii@chromium.org. ...
4 years, 5 months ago (2016-07-12 20:36:01 UTC) #18
tandrii(chromium)
Reopening.
4 years, 5 months ago (2016-07-12 20:39:01 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146523003/60001
4 years, 5 months ago (2016-07-12 20:43:11 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 20:45:28 UTC) #25
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://github.com/luci/recipes-py/commit/2b31483ac5f58781c138af391a35ccf3a3f...

Powered by Google App Engine
This is Rietveld 408576698