recipe_modules/shutil/example.py - Issue 2146523003: shutil recipe_module: port chromium_utils rmtree implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: recipe_modules/shutil/example.py

Issue 2146523003: shutil recipe_module: port chromium_utils rmtree implementation. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/recipes-py@master

Patch Set: nit Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: recipe_modules/shutil/example.py

diff --git a/recipe_modules/shutil/example.py b/recipe_modules/shutil/example.py

index 7c4d442c51d60526637092f1a0587b0b09615837..27d60d08956150b778a81255501a6115054c4a15 100644

--- a/recipe_modules/shutil/example.py

+++ b/recipe_modules/shutil/example.py

@@ -70,7 +70,7 @@ def RunSteps(api):

finally:

api.shutil.rmtree(tmp_dir, name='cleanup')

- api.shutil.rmtree(new_tmp, name='cleanup2')

+ api.shutil.rmtree(new_tmp, name='cleanup2', flag_smart_rmtree=True)

def GenTests(api):

« no previous file with comments | « recipe_modules/shutil/api.py ('k') | recipe_modules/shutil/example.expected/basic.json » ('j') | no next file with comments »