Fix V4L2VideoEncodeAccelerator is not enabled in GN build

Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram

Committed: https://crrev.com/f443335cc0f3c4f838db11c7117865b51e61bfdb
Cr-Commit-Position: refs/heads/master@{#405101}

[henryhsu, 2016-07-12 10:23:26]

henryhsu@chromium.org changed reviewers:
+ posciak@chromium.org, wuchengli@chromium.org

[henryhsu, 2016-07-12 10:23:26]

PTAL

[wuchengli, 2016-07-12 11:36:55]

Description was changed from

==========
Fix webrtc hardware encode

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.
For V4L2VEA, we should have the same condition for
GpuVideoEncodeAccelerator and unittest.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram
==========

to

==========
Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram
==========

[wuchengli, 2016-07-12 11:39:51]

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD.gn
File media/gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD...
media/gpu/ipc/service/BUILD.gn:41: public_configs = [ "//media/gpu:gpu_config" ]
s/public_configs/configs/. We don't need to propagate this to the dependents of
this target.

Please also help change public_configs to configs in
media/gpu/ipc/client/BUILD.gn.

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
File media/gpu/ipc/service/gpu_video_encode_accelerator.cc (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
media/gpu/ipc/service/gpu_video_encode_accelerator.cc:199: (defined(USE_OZONE)
&& defined(USE_V4L2_CODEC)))
This is not directly related to gn change. Please separate
gpu_video_encode_accelerator.h/gpu_video_encode_accelerator.cc to another CL.

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
File media/gpu/ipc/service/gpu_video_encode_accelerator.h (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
media/gpu/ipc/service/gpu_video_encode_accelerator.h:84: (defined(USE_OZONE) &&
defined(USE_V4L2_CODEC)))
Why do we need ozone? https://codereview.chromium.org/834113004 does the same. I
don't understand the relationship between having ozone and having v4l2 devices.
Don't all x86 have ozone?

This is not related to this CL. So if we don't need ozone, we can remove it in
another CL.

[wuchengli, 2016-07-12 15:00:55]

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD.gn
File media/gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD...
media/gpu/ipc/service/BUILD.gn:41: public_configs = [ "//media/gpu:gpu_config" ]
On 2016/07/12 11:39:51, wuchengli wrote:
> s/public_configs/configs/. We don't need to propagate this to the dependents
of
> this target.
> 
> Please also help change public_configs to configs in
> media/gpu/ipc/client/BUILD.gn.
I found why media/gpu/ipc/client/BUILD.gn used public_configs.
bpf_gpu_policy_linux.cc needs USE_LIBV4L2 and it depends on
media/gpu/ipc/client. No need to change media/gpu/ipc/client/BUILD.gn.

[ilja, 2016-07-12 21:21:37]

ihf@chromium.org changed reviewers:
+ ihf@chromium.org

[ilja, 2016-07-12 21:25:02]

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
File media/gpu/ipc/service/gpu_video_encode_accelerator.h (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
media/gpu/ipc/service/gpu_video_encode_accelerator.h:84: (defined(USE_OZONE) &&
defined(USE_V4L2_CODEC)))
All shipping boards except for tegra have ozone right now. But I think generic
builds might not have it. Of course that config is becoming less and less
relevant these days.

[wuchengli, 2016-07-13 02:24:10]

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
File media/gpu/ipc/service/gpu_video_encode_accelerator.h (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
media/gpu/ipc/service/gpu_video_encode_accelerator.h:84: (defined(USE_OZONE) &&
defined(USE_V4L2_CODEC)))
On 2016/07/12 21:25:02, ilja wrote:
> All shipping boards except for tegra have ozone right now. But I think generic
> builds might not have it. Of course that config is becoming less and less
> relevant these days.
I looked at the git history and old chromium issues. I'm sure USE_OZONE is not
needed here.

[henryhsu, 2016-07-13 03:29:59]

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD.gn
File media/gpu/ipc/service/BUILD.gn (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/BUILD...
media/gpu/ipc/service/BUILD.gn:41: public_configs = [ "//media/gpu:gpu_config" ]
On 2016/07/12 11:39:51, wuchengli wrote:
> s/public_configs/configs/. We don't need to propagate this to the dependents
of
> this target.
> 
> Please also help change public_configs to configs in
> media/gpu/ipc/client/BUILD.gn.

Done.

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
File media/gpu/ipc/service/gpu_video_encode_accelerator.h (right):

https://codereview.chromium.org/2146463002/diff/1/media/gpu/ipc/service/gpu_v...
media/gpu/ipc/service/gpu_video_encode_accelerator.h:84: (defined(USE_OZONE) &&
defined(USE_V4L2_CODEC)))
On 2016/07/13 02:24:10, wuchengli wrote:
> On 2016/07/12 21:25:02, ilja wrote:
> > All shipping boards except for tegra have ozone right now. But I think
generic
> > builds might not have it. Of course that config is becoming less and less
> > relevant these days.
> I looked at the git history and old chromium issues. I'm sure USE_OZONE is not
> needed here.

will remove in another cl

[wuchengli, 2016-07-13 06:52:17]

lgtm

[henryhsu, 2016-07-13 07:26:29]

The CQ bit was checked by henryhsu@chromium.org

[commit-bot: I haz the power, 2016-07-13 07:26:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 09:09:35]

Description was changed from

==========
Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram
==========

to

==========
Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram
==========

[commit-bot: I haz the power, 2016-07-13 09:09:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 09:09:40]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 09:11:08]

Description was changed from

==========
Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram
==========

to

==========
Fix V4L2VideoEncodeAccelerator is not enabled in GN build

USE_V4L2_CODEC is needed by GpuVideoEncodeAccelerator.

BUG=541408
TEST=check Media.RTCVideoEncoderInitEncodeSuccess histogram

Committed: https://crrev.com/f443335cc0f3c4f838db11c7117865b51e61bfdb
Cr-Commit-Position: refs/heads/master@{#405101}
==========

[commit-bot: I haz the power, 2016-07-13 09:11:10]

Patchset 2 (id:??) landed as
https://crrev.com/f443335cc0f3c4f838db11c7117865b51e61bfdb
Cr-Commit-Position: refs/heads/master@{#405101}