Add V4L2 device permissions on x86 CrOS which has ozone flag

Add V4L2 device permissions on x86 CrOS which has ozone flag

Some x86 CrOS platforms need to use V4L2 devices. It should have
USE_OZONE flag to have display support.

BUG=chromium:445016
TEST=build successfully on squawks and peach pit. Make sure v4l2 file
permissions are added on peach pit.

Committed: https://crrev.com/063c4bf6161de18c54df7531f576faa21c2249df
Cr-Commit-Position: refs/heads/master@{#310043}

[henryhsu, 2015-01-05 08:14:33]

henryhsu@chromium.org changed reviewers:
+ jorgelo@chromium.org, posciak@chromium.org, wuchengli@chromium.org

[henryhsu, 2015-01-05 08:14:33]

PTAL

[wuchengli, 2015-01-05 08:42:44]

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc (right):

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/bpf_cros_arm_gpu_policy_linux.cc:3: // found in the
LICENSE file.
This CL doesn't add the permission for all x86. Please update the title and says
this only works for ozone.

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right):

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:140:
std::vector<BrokerFilePermission> GetV4L2GpuWhitelist() {
Better to pass vector as a function parameter to be consistent with
AddArmGpuWhitelist().

void AddV4L2GpuWhiteList(std::vector<BrokerFilePermission>* permissions)

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:324: } else if
(IsArchitectureArm() || IsOzone()){
This is incorrect. From GetGpuProcessSandbox in sandbox_seccomp_bpf_linux.cc,
ARM only calls CrosArmGpuProcessPolicy. I think you need to have
GetV4L2GpuWhitelist in GpuProcessPolicy and CrosArmGpuProcessPolicy can call it.

You can also see GpuProcessPolicy::PreSandboxHook has DCHECK(!chromeos_arm_gpu).

The CL description said it worked on pit. I don't understand why.

[henryhsu, 2015-01-05 09:15:30]

all done

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
File content/common/sandbox_linux/bpf_gpu_policy_linux.cc (right):

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:140:
std::vector<BrokerFilePermission> GetV4L2GpuWhitelist() {
On 2015/01/05 08:42:44, wuchengli wrote:
> Better to pass vector as a function parameter to be consistent with
> AddArmGpuWhitelist().
> 
> void AddV4L2GpuWhiteList(std::vector<BrokerFilePermission>* permissions)

Done.

https://codereview.chromium.org/834113004/diff/1/content/common/sandbox_linux...
content/common/sandbox_linux/bpf_gpu_policy_linux.cc:324: } else if
(IsArchitectureArm() || IsOzone()){
On 2015/01/05 08:42:44, wuchengli wrote:
> This is incorrect. From GetGpuProcessSandbox in sandbox_seccomp_bpf_linux.cc,
> ARM only calls CrosArmGpuProcessPolicy. I think you need to have
> GetV4L2GpuWhitelist in GpuProcessPolicy and CrosArmGpuProcessPolicy can call
it.
> 
> You can also see GpuProcessPolicy::PreSandboxHook has
DCHECK(!chromeos_arm_gpu).
> 
> The CL description said it worked on pit. I don't understand why.

Arm only calls CrosArmGpuProcessPolicy. But it also calls InitGpuBrokerProcess
in CrosArmGpuProcessPolicy::PreSandboxHook. InitGpuBrokerProcess is a class
function of GpuProcessPolicy.

[wuchengli, 2015-01-05 13:09:00]

LGTM

[Jorge Lucangeli Obes, 2015-01-05 16:22:09]

lgtm

[henryhsu, 2015-01-06 02:28:47]

The CQ bit was checked by henryhsu@chromium.org

[commit-bot: I haz the power, 2015-01-06 02:29:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/834113004/20001

[commit-bot: I haz the power, 2015-01-06 03:34:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-06 03:35:21]

Patchset 2 (id:??) landed as
https://crrev.com/063c4bf6161de18c54df7531f576faa21c2249df
Cr-Commit-Position: refs/heads/master@{#310043}