Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Unified Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2146383002: ElementVisibilityObserver: get rid of reference cycle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
diff --git a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
index d8510e5b2f3c89ce163f74f4c6119939b50853c5..05f571387aa193c7b7269add45af7a5d4eb69c03 100644
--- a/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
+++ b/third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp
@@ -25,14 +25,14 @@ void ElementVisibilityObserver::start()
Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), &m_element->document(),
WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, wrapWeakPersistent(this)));
DCHECK(m_intersectionObserver);
- m_intersectionObserver->observe(m_element);
+ m_intersectionObserver->observe(m_element.release());
}
void ElementVisibilityObserver::stop()
{
DCHECK(m_intersectionObserver);
- m_intersectionObserver->unobserve(m_element);
+ m_intersectionObserver->disconnect();
m_intersectionObserver = nullptr;
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698