Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp

Issue 2146383002: ElementVisibilityObserver: get rid of reference cycle. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/Element.h" 7 #include "core/dom/Element.h"
8 #include "core/dom/IntersectionObserverEntry.h" 8 #include "core/dom/IntersectionObserverEntry.h"
9 #include "wtf/Functional.h" 9 #include "wtf/Functional.h"
10 10
11 namespace blink { 11 namespace blink {
12 12
13 ElementVisibilityObserver::ElementVisibilityObserver(Element* element, std::uniq ue_ptr<VisibilityCallback> callback) 13 ElementVisibilityObserver::ElementVisibilityObserver(Element* element, std::uniq ue_ptr<VisibilityCallback> callback)
14 : m_element(element) 14 : m_element(element)
15 , m_callback(std::move(callback)) 15 , m_callback(std::move(callback))
16 { 16 {
17 } 17 }
18 18
19 ElementVisibilityObserver::~ElementVisibilityObserver() = default; 19 ElementVisibilityObserver::~ElementVisibilityObserver() = default;
20 20
21 void ElementVisibilityObserver::start() 21 void ElementVisibilityObserver::start()
22 { 22 {
23 DCHECK(!m_intersectionObserver); 23 DCHECK(!m_intersectionObserver);
24 m_intersectionObserver = IntersectionObserver::create( 24 m_intersectionObserver = IntersectionObserver::create(
25 Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), &m _element->document(), 25 Vector<Length>(), Vector<float>({std::numeric_limits<float>::min()}), &m _element->document(),
26 WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, wrapWeakPersi stent(this))); 26 WTF::bind(&ElementVisibilityObserver::onVisibilityChanged, wrapWeakPersi stent(this)));
27 DCHECK(m_intersectionObserver); 27 DCHECK(m_intersectionObserver);
28 m_intersectionObserver->observe(m_element); 28 m_intersectionObserver->observe(m_element.release());
29 } 29 }
30 30
31 void ElementVisibilityObserver::stop() 31 void ElementVisibilityObserver::stop()
32 { 32 {
33 DCHECK(m_intersectionObserver); 33 DCHECK(m_intersectionObserver);
34 34
35 m_intersectionObserver->unobserve(m_element); 35 m_intersectionObserver->disconnect();
36 m_intersectionObserver = nullptr; 36 m_intersectionObserver = nullptr;
37 } 37 }
38 38
39 DEFINE_TRACE(ElementVisibilityObserver) 39 DEFINE_TRACE(ElementVisibilityObserver)
40 { 40 {
41 visitor->trace(m_element); 41 visitor->trace(m_element);
42 visitor->trace(m_intersectionObserver); 42 visitor->trace(m_intersectionObserver);
43 } 43 }
44 44
45 void ElementVisibilityObserver::onVisibilityChanged(const HeapVector<Member<Inte rsectionObserverEntry>>& entries) 45 void ElementVisibilityObserver::onVisibilityChanged(const HeapVector<Member<Inte rsectionObserverEntry>>& entries)
46 { 46 {
47 bool isVisible = entries.last()->intersectionRatio() > 0.f; 47 bool isVisible = entries.last()->intersectionRatio() > 0.f;
48 (*m_callback.get())(isVisible); 48 (*m_callback.get())(isVisible);
49 } 49 }
50 50
51 } // namespace blink 51 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObserver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698