[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against that library.
This CL fixes the shared library build with GYP.

TBR=erg

Committed: https://crrev.com/bdf33173c36e4adc006cfddc0f5ad290735262ba
Cr-Commit-Position: refs/heads/master@{#405602}

[Jakob Kummerow, 2016-07-14 14:32:35]

jkummerow@chromium.org changed reviewers:
+ erg@chromium.org, thomasanderson@google.com

[Jakob Kummerow, 2016-07-14 14:32:36]

Follow-up to https://codereview.chromium.org/2135353002.

The GN build handles this in
https://cs.chromium.org/chromium/src/build/config/linux/BUILD.gn?rcl=0&l=41

Tom: please review.
Elliot: OWNERS' approval please.

CQ it if you like it :-)

[Tom (Use chromium acct), 2016-07-14 16:11:06]

lgtm

[samueldoyle, 2016-07-14 20:39:26]

On 2016/07/14 16:11:06, Tom Anderson wrote:
> lgtm

I'm getting 

$ error while loading shared libraries: libgtk2ui.so: cannot open shared object
file: No such file or directory

after building today on Linux, guessing it is related?

[Tom (Use chromium acct), 2016-07-14 21:21:28]

On 2016/07/14 20:39:26, samueldoyle wrote:
> On 2016/07/14 16:11:06, Tom Anderson wrote:
> > lgtm
> 
> I'm getting 
> 
> $ error while loading shared libraries: libgtk2ui.so: cannot open shared
object
> file: No such file or directory
> 
> after building today on Linux, guessing it is related?

Sounds like it.  Can you try to selectively revert this change
https://codereview.chromium.org/2135353002
And see if that fixes your build?

[Dirk Pranke, 2016-07-14 21:29:17]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-07-14 21:29:17]

lgtm to me as well. Just TBR= erg@ and we should be okay.

[Tom (Use chromium acct), 2016-07-14 21:34:49]

Description was changed from

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.
==========

to

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.

TBR=erg
==========

[Tom (Use chromium acct), 2016-07-14 21:34:55]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2016-07-14 21:35:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 22:18:40]

Description was changed from

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.

TBR=erg
==========

to

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.

TBR=erg
==========

[commit-bot: I haz the power, 2016-07-14 22:18:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 22:18:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 22:19:54]

Description was changed from

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.

TBR=erg
==========

to

==========
[GYP/Linux] Add missing dependency on xcursor to libgtk2ui

Now that gtk2_ui.cc calls into libxcursor, libgtk2ui.so must be linked against
that library.
This CL fixes the shared library build with GYP.

TBR=erg

Committed: https://crrev.com/bdf33173c36e4adc006cfddc0f5ad290735262ba
Cr-Commit-Position: refs/heads/master@{#405602}
==========

[commit-bot: I haz the power, 2016-07-14 22:19:55]

Patchset 1 (id:??) landed as
https://crrev.com/bdf33173c36e4adc006cfddc0f5ad290735262ba
Cr-Commit-Position: refs/heads/master@{#405602}

[samueldoyle, 2016-07-14 22:34:05]

On 2016/07/14 21:21:28, Tom Anderson wrote:
> On 2016/07/14 20:39:26, samueldoyle wrote:
> > On 2016/07/14 16:11:06, Tom Anderson wrote:
> > > lgtm
> > 
> > I'm getting 
> > 
> > $ error while loading shared libraries: libgtk2ui.so: cannot open shared
> object
> > file: No such file or directory
> > 
> > after building today on Linux, guessing it is related?
> 
> Sounds like it.  Can you try to selectively revert this change
> https://codereview.chromium.org/2135353002
> And see if that fixes your build?

I'll try to pull a clean copy of the repo. 
I've had cases in the past before where even though I would perform a clean
build it would still fail even after running the install build deps again,
pulling the src again would resolve it.