Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2135353002:
Linux: Add support for custom cursor themes (Closed)
|
Created:
4 years, 5 months ago by Tom (Use chromium acct) Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionLinux: Add support for custom cursor themes
Use the cursor theme that GTK tells us is the default,
instead of always using the default white cursor theme.
BUG=377525
Committed: https://crrev.com/d03183157a0b175943275b05ad2c5eca334d7f19
Cr-Commit-Position: refs/heads/master@{#405261}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fix include order and add failchecks #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== Add support for custom cursor themes BUG=377525 ========== to ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ==========
thomasanderson@google.com changed reviewers: + thestig@chromium.org
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Description was changed from ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ========== to ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
thestig@chromium.org changed reviewers: + erg@chromium.org
Looks ok, but I defer to chrome/browser/ui/libgtk2ui/OWNERS https://codereview.chromium.org/2135353002/diff/1/chrome/browser/ui/libgtk2ui... File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2135353002/diff/1/chrome/browser/ui/libgtk2ui... chrome/browser/ui/libgtk2ui/gtk2_ui.cc:11: #include <X11/Xcursor/Xcursor.h> nit: C headers above C++ headers.
https://codereview.chromium.org/2135353002/diff/1/chrome/browser/ui/libgtk2ui... File chrome/browser/ui/libgtk2ui/gtk2_ui.cc (right): https://codereview.chromium.org/2135353002/diff/1/chrome/browser/ui/libgtk2ui... chrome/browser/ui/libgtk2ui/gtk2_ui.cc:11: #include <X11/Xcursor/Xcursor.h> On 2016/07/11 22:34:56, Lei Zhang wrote: > nit: C headers above C++ headers. Done.
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
thomasanderson@google.com changed reviewers: + estade@chromium.org
+estade@ because erg is OOO
lgtm
The CQ bit was checked by thomasanderson@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ========== to ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 ========== to ========== Linux: Add support for custom cursor themes Use the cursor theme that GTK tells us is the default, instead of always using the default white cursor theme. BUG=377525 Committed: https://crrev.com/d03183157a0b175943275b05ad2c5eca334d7f19 Cr-Commit-Position: refs/heads/master@{#405261} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/d03183157a0b175943275b05ad2c5eca334d7f19 Cr-Commit-Position: refs/heads/master@{#405261} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
