Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js

Issue 2146333003: [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: a Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
index 2c913c817c54df7657b038e06b22e36fb9cf29d1..483b8b59b2b0045e5be4221ecc953fb5e4ba648b 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js
@@ -357,7 +357,7 @@ WebInspector.DebuggerModel.prototype = {
/**
* @param {!RuntimeAgent.ScriptId} scriptId
* @param {string} newSource
- * @param {function(?Protocol.Error, !DebuggerAgent.SetScriptSourceError=)} callback
+ * @param {function(?Protocol.Error, !RuntimeAgent.ExceptionDetails=)} callback
*/
setScriptSource: function(scriptId, newSource, callback)
{
@@ -367,24 +367,24 @@ WebInspector.DebuggerModel.prototype = {
/**
* @param {!RuntimeAgent.ScriptId} scriptId
* @param {string} newSource
- * @param {function(?Protocol.Error, !DebuggerAgent.SetScriptSourceError=)} callback
+ * @param {function(?Protocol.Error, !RuntimeAgent.ExceptionDetails=)} callback
* @param {?Protocol.Error} error
- * @param {!DebuggerAgent.SetScriptSourceError=} errorData
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
* @param {!Array.<!DebuggerAgent.CallFrame>=} callFrames
* @param {!RuntimeAgent.StackTrace=} asyncStackTrace
* @param {boolean=} needsStepIn
*/
- _didEditScriptSource: function(scriptId, newSource, callback, error, errorData, callFrames, asyncStackTrace, needsStepIn)
+ _didEditScriptSource: function(scriptId, newSource, callback, error, exceptionDetails, callFrames, asyncStackTrace, needsStepIn)
{
if (needsStepIn) {
this.stepInto();
- this._pendingLiveEditCallback = callback.bind(this, error, errorData);
+ this._pendingLiveEditCallback = callback.bind(this, error, exceptionDetails);
return;
}
if (!error && callFrames && callFrames.length)
this._pausedScript(callFrames, this._debuggerPausedDetails.reason, this._debuggerPausedDetails.auxData, this._debuggerPausedDetails.breakpointIds, asyncStackTrace);
- callback(error, errorData);
+ callback(error, exceptionDetails);
},
/**

Powered by Google App Engine
This is Rietveld 408576698