third_party/WebKit/Source/devtools/front_end/sdk/Script.js - Issue 2146333003: [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Script.js

Issue 2146333003: [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: a Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js ('k') | third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/Script.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js

index 540c494c407083530ffa7dbf845b27852de2dcaa..2e91baca71521197080ab9a35f26e38a67655e46 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js

@@ -218,7 +218,7 @@ WebInspector.Script.prototype = {

/**

* @param {string} newSource

- * @param {function(?Protocol.Error, !DebuggerAgent.SetScriptSourceError=, !Array.<!DebuggerAgent.CallFrame>=, !RuntimeAgent.StackTrace=, boolean=)} callback

+ * @param {function(?Protocol.Error, !RuntimeAgent.ExceptionDetails=, !Array.<!DebuggerAgent.CallFrame>=, !RuntimeAgent.StackTrace=, boolean=)} callback

editSource: function(newSource, callback)

{

@@ -228,7 +228,7 @@ WebInspector.Script.prototype = {

* @param {!Array.<!DebuggerAgent.CallFrame>=} callFrames

* @param {boolean=} stackChanged

* @param {!RuntimeAgent.StackTrace=} asyncStackTrace

- * @param {!DebuggerAgent.SetScriptSourceError=} compileError

+ * @param {!RuntimeAgent.ExceptionDetails=} compileError

function didEditScriptSource(error, callFrames, stackChanged, asyncStackTrace, compileError)

{