Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2146333003: [DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Replace SetScriptSourceError with ExceptionDetails in protocol BUG=591496 R=dgozman@chromium.org Committed: https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19 Cr-Commit-Position: refs/heads/master@{#405898}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : a #

Messages

Total messages: 21 (11 generated)
kozy
Dmitry, please take a look!
4 years, 5 months ago (2016-07-15 01:25:57 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-15 01:30:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146333003/20001
4 years, 5 months ago (2016-07-15 17:23:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/256767)
4 years, 5 months ago (2016-07-15 19:18:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146333003/20001
4 years, 5 months ago (2016-07-15 19:47:40 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/256799)
4 years, 5 months ago (2016-07-15 20:42:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146333003/40001
4 years, 5 months ago (2016-07-15 22:27:19 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 23:36:03 UTC) #18
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 23:36:07 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 23:38:20 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ce719653064ea664fc422579441bfee3454ccb19
Cr-Commit-Position: refs/heads/master@{#405898}

Powered by Google App Engine
This is Rietveld 408576698