Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2146303002:
Fixing a cursor position initialization problem (Closed)
DescriptionFixing a cursor position initialization problem
This issue was caused during a recent refactoring. This CL adds the
initialization code for Trackpad mode back.
BUG=628034
Committed: https://crrev.com/1bbf9d224609df203040da6e2d3d9f7d39c2cd91
Cr-Commit-Position: refs/heads/master@{#405610}
Patch Set 1 #Patch Set 2 : Removing an unused variable. #Patch Set 3 : Fixing a mismatch between exact center position and image placement. #Patch Set 4 : Refactoring cleanup #
Total comments: 2
Patch Set 5 : Addressing CR Feedback #
Messages
Total messages: 26 (18 generated)
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
joedow@chromium.org changed reviewers: + lambroslambrou@chromium.org
PTAL! Thanks, Joe
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm after addressing comment. https://codereview.chromium.org/2146303002/diff/60001/remoting/android/java/s... File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java (right): https://codereview.chromium.org/2146303002/diff/60001/remoting/android/java/s... remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:650: return (mappedPoints[0] < 0 && mappedPoints[0] > imageWidth) The '&&'s should be ||, and the parentheses are not needed. Should be: x < 0 || x > width || y < 0 || y > height Also, because of floating-point rounding errors, perhaps we should allow a slight margin of error? x < -epsilon || x > width + epsilon ... where epsilon is some small number. Guess it depends what this will be used for?
The CQ bit was checked by joedow@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2146303002/diff/60001/remoting/android/java/s... File remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java (right): https://codereview.chromium.org/2146303002/diff/60001/remoting/android/java/s... remoting/android/java/src/org/chromium/chromoting/TouchInputHandler.java:650: return (mappedPoints[0] < 0 && mappedPoints[0] > imageWidth) On 2016/07/14 21:11:08, Lambros wrote: > The '&&'s should be ||, and the parentheses are not needed. > Should be: x < 0 || x > width || y < 0 || y > height > > Also, because of floating-point rounding errors, perhaps we should allow a > slight margin of error? > x < -epsilon || x > width + epsilon ... > where epsilon is some small number. > Guess it depends what this will be used for? Oh geez, not sure why I didn't catch this in my testing. Fixed now :) I'm fine adding a small fudge factor to this as well.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by joedow@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lambroslambrou@chromium.org Link to the patchset: https://codereview.chromium.org/2146303002/#ps80001 (title: "Addressing CR Feedback")
Thanks!
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Fixing a cursor position initialization problem This issue was caused during a recent refactoring. This CL adds the initialization code for Trackpad mode back. BUG=628034 ========== to ========== Fixing a cursor position initialization problem This issue was caused during a recent refactoring. This CL adds the initialization code for Trackpad mode back. BUG=628034 Committed: https://crrev.com/1bbf9d224609df203040da6e2d3d9f7d39c2cd91 Cr-Commit-Position: refs/heads/master@{#405610} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/1bbf9d224609df203040da6e2d3d9f7d39c2cd91 Cr-Commit-Position: refs/heads/master@{#405610} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
