src/compiler/code-assembler.cc - Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/code-assembler.cc

Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add a basic impl in ElementsAccessor, cleanup %ArrayIncludes_Slow, lots of new tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/code-assembler.cc

diff --git a/src/compiler/code-assembler.cc b/src/compiler/code-assembler.cc

index 46208751cd7bbdc2bf5a26833a4d44ecae9abcf5..6547c832e1dafb7aef54ffebfb96cc831a8aeb84 100644

--- a/src/compiler/code-assembler.cc

+++ b/src/compiler/code-assembler.cc

@@ -709,7 +709,7 @@ void CodeAssembler::Branch(Node* condition, CodeAssembler::Label* true_label,

}

void CodeAssembler::Switch(Node* index, Label* default_label,

- int32_t* case_values, Label** case_labels,

+ const int32_t* case_values, Label** case_labels,

size_t case_count) {

RawMachineLabel** labels =

new (zone()->New(sizeof(RawMachineLabel*) * case_count))