src/compiler/raw-machine-assembler.h - Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/raw-machine-assembler.h

Issue 2146293003: [builtins] implement Array.prototype.includes in TurboFan (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add a basic impl in ElementsAccessor, cleanup %ArrayIncludes_Slow, lots of new tests Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/raw-machine-assembler.h

diff --git a/src/compiler/raw-machine-assembler.h b/src/compiler/raw-machine-assembler.h

index 264637d23321b2866c564730ef90382a35d7c02e..3a3f510d2b4064154acd19e9b8b228fa23364192 100644

--- a/src/compiler/raw-machine-assembler.h

+++ b/src/compiler/raw-machine-assembler.h

@@ -721,8 +721,9 @@ class RawMachineAssembler {

void Goto(RawMachineLabel* label);

void Branch(Node* condition, RawMachineLabel* true_val,

RawMachineLabel* false_val);

- void Switch(Node* index, RawMachineLabel* default_label, int32_t* case_values,

- RawMachineLabel** case_labels, size_t case_count);

+ void Switch(Node* index, RawMachineLabel* default_label,

+ const int32_t* case_values, RawMachineLabel** case_labels,

+ size_t case_count);

void Return(Node* value);

void Return(Node* v1, Node* v2);

void Return(Node* v1, Node* v2, Node* v3);