DevTools: reuse computedstylesmodel in the elements sidebar base class.

DevTools: reuse computedstylesmodel in the elements sidebar base class.

BUG=627306
Committed: https://crrev.com/afb1b53171bcf35dd24053a467f4bdf64dfc425a
Cr-Commit-Position: refs/heads/master@{#405582}

[pfeldman, 2016-07-13 23:31:57]

pfeldman@chromium.org changed reviewers:
+ lushnikov@chromium.org

[lushnikov, 2016-07-14 00:58:15]

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:85:
_onComputedStyleChanged: function(event)
nit: indent is off here (do you use eslint?)

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:88:
this.dispatchEventToListeners(WebInspector.ComputedStyleModel.Events.ComputedStyleChanged,
event);
event.data || null

(This will save from writing ugly event.data && event.data.data later)

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:158:
__proto__: WebInspector.Object.prototype
nit: indent

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js:13:
this._computedStyleModel = new WebInspector.ComputedStyleModel();
Looks like this will result in re-requesting computed styles twice for a single
node? (once from ComputedStyleWidget and once from here)

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:56:
WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode,
this.onUndoOrRedoHappened, this);
s/onUndoOrRedoHappened/forceUpdate will make it easier to follow

[pfeldman, 2016-07-14 17:26:12]

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:85:
_onComputedStyleChanged: function(event)
On 2016/07/14 00:58:14, lushnikov wrote:
> nit: indent is off here (do you use eslint?)

nope

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:88:
this.dispatchEventToListeners(WebInspector.ComputedStyleModel.Events.ComputedStyleChanged,
event);
On 2016/07/14 00:58:15, lushnikov wrote:
> event.data || null
> 
> (This will save from writing ugly event.data && event.data.data later)

Done.

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js:158:
__proto__: WebInspector.Object.prototype
On 2016/07/14 00:58:15, lushnikov wrote:
> nit: indent

Done.

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js:13:
this._computedStyleModel = new WebInspector.ComputedStyleModel();
On 2016/07/14 00:58:15, lushnikov wrote:
> Looks like this will result in re-requesting computed styles twice for a
single
> node? (once from ComputedStyleWidget and once from here)
> 

Not unless you call fetchComputedStyle on it.

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js
(right):

https://codereview.chromium.org/2146233002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js:56:
WebInspector.context.addFlavorChangeListener(WebInspector.DOMNode,
this.onUndoOrRedoHappened, this);
On 2016/07/14 00:58:15, lushnikov wrote:
> s/onUndoOrRedoHappened/forceUpdate will make it easier to follow

Done.

[pfeldman, 2016-07-14 17:36:04]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 17:36:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:50:58]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-07-14 21:25:34]

lgtm

this will also fix the crbug.com/623317!

[pfeldman, 2016-07-14 21:33:07]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-07-14 21:34:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 21:42:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 21:43:09]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 21:44:23]

Description was changed from

==========
DevTools: reuse computedstylesmodel in the elements sidebar base class.

BUG=627306
==========

to

==========
DevTools: reuse computedstylesmodel in the elements sidebar base class.

BUG=627306

Committed: https://crrev.com/afb1b53171bcf35dd24053a467f4bdf64dfc425a
Cr-Commit-Position: refs/heads/master@{#405582}
==========

[commit-bot: I haz the power, 2016-07-14 21:44:24]

Patchset 3 (id:??) landed as
https://crrev.com/afb1b53171bcf35dd24053a467f4bdf64dfc425a
Cr-Commit-Position: refs/heads/master@{#405582}