third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js - Issue 2146233002: DevTools: reuse computedstylesmodel in the elements sidebar base class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

Issue 2146233002: DevTools: reuse computedstylesmodel in the elements sidebar base class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: (2) Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/elements/ElementsSidebarPane.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js b/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

index 670ca2bb82a168b3dca10ec8711ad4a4a312ebf4..b770aea265b5d33b0b577fcd110f03b0f4b7c2cf 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/MetricsSidebarPane.js

@@ -86,28 +86,12 @@ WebInspector.MetricsSidebarPane.prototype = {

/**

* @override

- onDOMModelChanged: function()

- {

- this.update();

- },

- /**

- * @override

- */

onCSSModelChanged: function()

{

this.update();

/**

- * @override

- */

- onFrameResizedThrottled: function()

- {

- this.update();

- },

- /**

* @param {!Map.<string, string>} style

* @param {string} propertyName

* @return {number}

@@ -469,7 +453,7 @@ WebInspector.MetricsSidebarPane.prototype = {

this.originalPropertyData = this.previousPropertyDataCandidate;

if (typeof this._highlightMode !== "undefined")

- this._node.highlight(this._highlightMode);

+ this.node().highlight(this._highlightMode);

if (commitEditor)

this.update();