Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: base/task_scheduler/task_scheduler_impl.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/task_scheduler_impl.cc
diff --git a/base/task_scheduler/task_scheduler_impl.cc b/base/task_scheduler/task_scheduler_impl.cc
index 2f5b68f6a78f6328580d95302a8905805801659b..a42812e0404c67ae8fc22a9f35055a568471777d 100644
--- a/base/task_scheduler/task_scheduler_impl.cc
+++ b/base/task_scheduler/task_scheduler_impl.cc
@@ -12,6 +12,7 @@
#include "base/task_scheduler/scheduler_service_thread.h"
#include "base/task_scheduler/sequence_sort_key.h"
#include "base/task_scheduler/task.h"
+#include "base/task_scheduler/worker_pool_params.h"
#include "base/time/time.h"
namespace base {
@@ -19,7 +20,7 @@ namespace internal {
// static
std::unique_ptr<TaskSchedulerImpl> TaskSchedulerImpl::Create(
- const std::vector<WorkerPoolCreationArgs>& worker_pools,
+ const std::vector<WorkerPoolParams>& worker_pools,
const WorkerPoolIndexForTraitsCallback&
worker_pool_index_for_traits_callback) {
std::unique_ptr<TaskSchedulerImpl> scheduler(
@@ -84,7 +85,7 @@ TaskSchedulerImpl::TaskSchedulerImpl(const WorkerPoolIndexForTraitsCallback&
}
void TaskSchedulerImpl::Initialize(
- const std::vector<WorkerPoolCreationArgs>& worker_pools) {
+ const std::vector<WorkerPoolParams>& worker_pools) {
DCHECK(!worker_pools.empty());
const SchedulerWorkerPoolImpl::ReEnqueueSequenceCallback
@@ -96,9 +97,8 @@ void TaskSchedulerImpl::Initialize(
// SchedulerWorkerPoolImpl::Create() is safe because a TaskSchedulerImpl
// can't be deleted before all its worker pools have been joined.
worker_pools_.push_back(SchedulerWorkerPoolImpl::Create(
- worker_pool.name, worker_pool.thread_priority, worker_pool.max_threads,
- worker_pool.io_restriction, re_enqueue_sequence_callback,
- &task_tracker_, &delayed_task_manager_));
+ worker_pool, re_enqueue_sequence_callback, &task_tracker_,
+ &delayed_task_manager_));
CHECK(worker_pools_.back());
}

Powered by Google App Engine
This is Rietveld 408576698